You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/10 16:00:49 UTC

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10451: fix(chart-data-api): assert referenced columns are present in datasource

codecov-commenter commented on pull request #10451:
URL: https://github.com/apache/incubator-superset/pull/10451#issuecomment-671442156


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10451?src=pr&el=h1) Report
   > Merging [#10451](https://codecov.io/gh/apache/incubator-superset/pull/10451?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7f84927504fd27b1e4a05710ef81e63687b81895&el=desc) will **increase** coverage by `0.38%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10451/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10451?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10451      +/-   ##
   ==========================================
   + Coverage   59.49%   59.88%   +0.38%     
   ==========================================
     Files         767      413     -354     
     Lines       36282    13433   -22849     
     Branches     3430     3430              
   ==========================================
   - Hits        21587     8044   -13543     
   + Misses      14502     5196    -9306     
     Partials      193      193              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.88% <ø> (ø)` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10451?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...sions/db4b49eb0782\_add\_tables\_for\_sql\_lab\_state.py](https://codecov.io/gh/apache/incubator-superset/pull/10451/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kYjRiNDllYjA3ODJfYWRkX3RhYmxlc19mb3Jfc3FsX2xhYl9zdGF0ZS5weQ==) | | |
   | [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10451/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | | |
   | [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10451/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10451/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | | |
   | [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10451/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | | |
   | [superset/migrations/versions/1e2841a4128\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10451/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xZTI4NDFhNDEyOF8ucHk=) | | |
   | [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/10451/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | | |
   | [...set/migrations/versions/d94d33dbe938\_form\_strip.py](https://codecov.io/gh/apache/incubator-superset/pull/10451/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kOTRkMzNkYmU5MzhfZm9ybV9zdHJpcC5weQ==) | | |
   | [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/10451/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | | |
   | [...318dfe5fb6c\_adding\_verbose\_name\_to\_druid\_column.py](https://codecov.io/gh/apache/incubator-superset/pull/10451/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iMzE4ZGZlNWZiNmNfYWRkaW5nX3ZlcmJvc2VfbmFtZV90b19kcnVpZF9jb2x1bW4ucHk=) | | |
   | ... and [339 more](https://codecov.io/gh/apache/incubator-superset/pull/10451/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10451?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10451?src=pr&el=footer). Last update [7f84927...560211a](https://codecov.io/gh/apache/incubator-superset/pull/10451?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org