You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/29 07:10:57 UTC
[GitHub] [spark] MaxGekk opened a new pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
MaxGekk opened a new pull request #30180:
URL: https://github.com/apache/spark/pull/30180
### What changes were proposed in this pull request?
Return schema in SQL format instead of Catalog string from the SchemaOfCsv expression.
### Why are the changes needed?
To unify output of the `schema_of_json()` and `schema_of_csv()`.
### Does this PR introduce _any_ user-facing change?
Yes, they can but `schema_of_csv()` is usually used in combination with `from_csv()`, so, the format of schema shouldn't be much matter.
Before:
```
> SELECT schema_of_csv('1,abc');
struct<_c0:int,_c1:string>
```
After:
```
> SELECT schema_of_csv('1,abc');
STRUCT<`_c0`: INT, `_c1`: STRING>
```
### How was this patch tested?
By existing test suites `CsvFunctionsSuite` and `CsvExpressionsSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30180:
URL: https://github.com/apache/spark/pull/30180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718445900
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35000/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718471117
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718411813
**[Test build #130398 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130398/testReport)** for PR 30180 at commit [`cb1215a`](https://github.com/apache/spark/commit/cb1215a2d600af4f85131ea76934db871c0d7cf0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718477255
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718477255
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718471117
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718411813
**[Test build #130398 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130398/testReport)** for PR 30180 at commit [`cb1215a`](https://github.com/apache/spark/commit/cb1215a2d600af4f85131ea76934db871c0d7cf0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718477194
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35002/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30180:
URL: https://github.com/apache/spark/pull/30180#discussion_r514043757
##########
File path: R/pkg/tests/fulltests/test_sparkSQL.R
##########
@@ -1682,9 +1682,9 @@ test_that("column functions", {
df <- as.DataFrame(list(list("col" = "1")))
c <- collect(select(df, schema_of_csv("Amsterdam,2018")))
- expect_equal(c[[1]], "struct<_c0:string,_c1:int>")
+ expect_equal(c[[1]], "STRUCT<`_c0`: STRING, `_c1`: INT>")
Review comment:
Let's also add in migration guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #30180:
URL: https://github.com/apache/spark/pull/30180#discussion_r514044135
##########
File path: R/pkg/tests/fulltests/test_sparkSQL.R
##########
@@ -1682,9 +1682,9 @@ test_that("column functions", {
df <- as.DataFrame(list(list("col" = "1")))
c <- collect(select(df, schema_of_csv("Amsterdam,2018")))
- expect_equal(c[[1]], "struct<_c0:string,_c1:int>")
+ expect_equal(c[[1]], "STRUCT<`_c0`: STRING, `_c1`: INT>")
Review comment:
yah, I am doing that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718707742
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718456575
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35002/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718701720
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718471067
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35000/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718477280
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35002/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718700755
**[Test build #130398 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130398/testReport)** for PR 30180 at commit [`cb1215a`](https://github.com/apache/spark/commit/cb1215a2d600af4f85131ea76934db871c0d7cf0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30180: [SPARK-33281][SQL] Return SQL schema instead of Catalog string from the `SchemaOfCsv` expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30180:
URL: https://github.com/apache/spark/pull/30180#issuecomment-718701720
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org