You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/24 11:06:20 UTC
[GitHub] [airflow] lokeshlal opened a new pull request #6889: V1 10 stable
lokeshlal opened a new pull request #6889: V1 10 stable
URL: https://github.com/apache/airflow/pull/6889
### Description
- Added dynamic pooling within Airflow
### Tests
- PR does not need modification in test cases as the parameter which we changed is related to pool_capacity occupied by an individual task and should be handled by existing test cases
### Documentation
Modified following files:
1. Added a migration file 4edd1e752c7a_add_pool_capacity_field_to_taskinstance.py to add the pool_capacity in db
2. Models
2.1 pool.py - changed the logic to calculate the open and occupied slots
2.2 taskinstance.py - added the pool_capacity properpty
2.3 baseoperator.py - added the pool_capacity properpty
3. ti_deps
3.1 pool_slots_available_dep.py - modified the logic based upon pool_capacity
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6889: Dynamic Pooling [V1
10 stable]
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6889: Dynamic Pooling [V1 10 stable]
URL: https://github.com/apache/airflow/pull/6889#issuecomment-570124742
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6889?src=pr&el=h1) Report
> Merging [#6889](https://codecov.io/gh/apache/airflow/pull/6889?src=pr&el=desc) into [v1-10-stable](https://codecov.io/gh/apache/airflow/commit/c8597cbf143b970ad3c7b0d62e3b44d1dfdc8afe?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `25%`.
[](https://codecov.io/gh/apache/airflow/pull/6889?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-stable #6889 +/- ##
================================================
- Coverage 81.5% 81.41% -0.09%
================================================
Files 526 526
Lines 36032 36085 +53
================================================
+ Hits 29368 29380 +12
- Misses 6664 6705 +41
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6889?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6889/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.05% <100%> (+0.02%)` | :arrow_up: |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6889/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `95.27% <100%> (+0.01%)` | :arrow_up: |
| [airflow/ti\_deps/deps/pool\_slots\_available\_dep.py](https://codecov.io/gh/apache/airflow/pull/6889/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcG9vbF9zbG90c19hdmFpbGFibGVfZGVwLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6889/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `45.67% <12.76%> (-0.91%)` | :arrow_down: |
| [airflow/models/pool.py](https://codecov.io/gh/apache/airflow/pull/6889/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvcG9vbC5weQ==) | `95% <66.66%> (-2.37%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6889/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `91.88% <0%> (-0.17%)` | :arrow_down: |
| [airflow/task/task\_runner/base\_task\_runner.py](https://codecov.io/gh/apache/airflow/pull/6889/diff?src=pr&el=tree#diff-YWlyZmxvdy90YXNrL3Rhc2tfcnVubmVyL2Jhc2VfdGFza19ydW5uZXIucHk=) | `90.47% <0%> (+3.17%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6889?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6889?src=pr&el=footer). Last update [c8597cb...5c4fb45](https://codecov.io/gh/apache/airflow/pull/6889?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] lokeshlal closed pull request #6889: Dynamic Pooling [V1
10 stable]
Posted by GitBox <gi...@apache.org>.
lokeshlal closed pull request #6889: Dynamic Pooling [V1 10 stable]
URL: https://github.com/apache/airflow/pull/6889
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services