[superset] branch master updated: fix(explore): missing select when groupby without metrics (#12890)

[vi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 36c4311  fix(explore): missing select when groupby without metrics (#12890)
36c4311 is described below

commit 36c43113e7c5ae88015341e64b12ab310e9ef048
Author: Ville Brofeldt <33...@users.noreply.github.com>
AuthorDate: Tue Feb 2 17:14:30 2021 +0200

    fix(explore): missing select when groupby without metrics (#12890)
---
 superset/connectors/sqla/models.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
index c0c7c5d..1881e68 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -967,7 +967,7 @@ class SqlaTable(  # pylint: disable=too-many-public-methods,too-many-instance-at
         columns = columns or []
         columns = [col for col in columns if col != utils.DTTM_ALIAS]
 
-        if (is_sip_38 and metrics and columns) or (not is_sip_38 and metrics):
+        if metrics or groupby:
             # dedup columns while preserving order
             columns = columns if is_sip_38 else (groupby or columns)
             select_exprs = []