You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by wa...@apache.org on 2021/01/04 05:15:33 UTC
[hbase] branch branch-2 updated: HBASE-25435 Slow metric value can
be configured
This is an automated email from the ASF dual-hosted git repository.
wangzheng pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2 by this push:
new e517bf7 HBASE-25435 Slow metric value can be configured
e517bf7 is described below
commit e517bf705899cbde02a308a8ec2f6f81a47a87e3
Author: leyangyueshan <15...@163.com>
AuthorDate: Thu Dec 31 22:37:31 2020 +0800
HBASE-25435 Slow metric value can be configured
Signed-off-by: jediwang <je...@tencent.com>
---
.../hadoop/hbase/regionserver/MetricsRegionServer.java | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
index 5b05c12..68b0890 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
@@ -42,6 +42,7 @@ public class MetricsRegionServer {
"hbase.regionserver.enable.table.latencies";
public static final boolean RS_ENABLE_TABLE_METRICS_DEFAULT = true;
+ public static final String SLOW_METRIC_TIME = "hbase.ipc.slow.metric.time";
private final MetricsRegionServerSource serverSource;
private final MetricsRegionServerWrapper regionServerWrapper;
private RegionServerTableMetrics tableMetrics;
@@ -53,6 +54,8 @@ public class MetricsRegionServer {
private Timer bulkLoadTimer;
private Meter serverReadQueryMeter;
private Meter serverWriteQueryMeter;
+ protected long slowMetricTime;
+ protected static final int DEFAULT_SLOW_METRIC_TIME = 1000; // milliseconds
public MetricsRegionServer(MetricsRegionServerWrapper regionServerWrapper, Configuration conf,
MetricsTable metricsTable) {
@@ -67,7 +70,8 @@ public class MetricsRegionServer {
// create and use metrics from the new hbase-metrics based registry.
bulkLoadTimer = metricRegistry.timer("Bulkload");
-
+
+ slowMetricTime = conf.getLong(SLOW_METRIC_TIME, DEFAULT_SLOW_METRIC_TIME);
serverReadQueryMeter = metricRegistry.meter("ServerReadQueryPerSecond");
serverWriteQueryMeter = metricRegistry.meter("ServerWriteQueryPerSecond");
quotaSource = CompatibilitySingletonFactory.getInstance(MetricsRegionServerQuotaSource.class);
@@ -109,7 +113,7 @@ public class MetricsRegionServer {
if (tableMetrics != null && tn != null) {
tableMetrics.updatePutBatch(tn, t);
}
- if (t > 1000) {
+ if (t > slowMetricTime) {
serverSource.incrSlowPut();
}
serverSource.updatePutBatch(t);
@@ -135,7 +139,7 @@ public class MetricsRegionServer {
if (tableMetrics != null && tn != null) {
tableMetrics.updateDeleteBatch(tn, t);
}
- if (t > 1000) {
+ if (t > slowMetricTime) {
serverSource.incrSlowDelete();
}
serverSource.updateDeleteBatch(t);
@@ -166,7 +170,7 @@ public class MetricsRegionServer {
if (tableMetrics != null && tn != null) {
tableMetrics.updateGet(tn, t);
}
- if (t > 1000) {
+ if (t > slowMetricTime) {
serverSource.incrSlowGet();
}
serverSource.updateGet(t);
@@ -177,7 +181,7 @@ public class MetricsRegionServer {
if (tableMetrics != null && tn != null) {
tableMetrics.updateIncrement(tn, t);
}
- if (t > 1000) {
+ if (t > slowMetricTime) {
serverSource.incrSlowIncrement();
}
serverSource.updateIncrement(t);
@@ -188,7 +192,7 @@ public class MetricsRegionServer {
if (tableMetrics != null && tn != null) {
tableMetrics.updateAppend(tn, t);
}
- if (t > 1000) {
+ if (t > slowMetricTime) {
serverSource.incrSlowAppend();
}
serverSource.updateAppend(t);