You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/06/23 12:28:51 UTC

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

lipenglin@sensorsdata.cn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18658


Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................

IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

This commit implements cloning between Iceberg tables. Cloning Iceberg
tables from other Types of tables is not implemented, because the Data
Types of Iceberg and Impala do not correspond one by one.

Testing:
 - e2e tests

Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
---
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
8 files changed, 521 insertions(+), 47 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18658/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8298/


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 14:40:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................

IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

This commit implements cloning between Iceberg tables. Cloning Iceberg
tables from other Types of tables is not implemented, because the Data
Types of Iceberg and Impala do not correspond one by one.

Testing:
 - e2e tests

Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
---
M docs/topics/impala_iceberg.xml
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
8 files changed, 665 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18658/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................

IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

This commit implements cloning between Iceberg tables. Cloning Iceberg
tables from other Types of tables is not implemented, because the Data
Types of Iceberg and Impala do not correspond one by one.

Testing:
 - e2e tests

Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
---
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
8 files changed, 524 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18658/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................

IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

This commit implements cloning between Iceberg tables. Cloning Iceberg
tables from other Types of tables is not implemented, because the Data
Types of Iceberg and Impala do not correspond one by one.

Testing:
 - e2e tests

Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
7 files changed, 645 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18658/9
-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10872/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Jun 2022 18:12:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8298/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 09:57:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 9: Code-Review+2

Thanks! LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jul 2022 13:52:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 9: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jul 2022 07:59:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 9:

Fix flaky e2e test.


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jul 2022 08:06:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 4:

(4 comments)

Thank you for working on this!

Could you please document this new feature in docs/topics/impala_iceberg.xml ?

http://gerrit.cloudera.org:8080/#/c/18658/4/common/thrift/JniCatalog.thrift
File common/thrift/JniCatalog.thrift:

http://gerrit.cloudera.org:8080/#/c/18658/4/common/thrift/JniCatalog.thrift@514
PS4, Line 514: required
I think this sholud be optional as we haven't use this field earlier.

Also, can't we just use the source table at the Catalog-side to retrieve the columns?


http://gerrit.cloudera.org:8080/#/c/18658/4/common/thrift/JniCatalog.thrift@516
PS4, Line 516:   // Current PartitionSpec of Iceberg tables
             :   13: optional CatalogObjects.TIcebergPartitionSpec partition_spec
             : 
             :   // Map of string properties for Iceberg tables
             :   14: optional map<string, string> table_properties
Can't we retrieve this information at the Catalog side from the source table?


http://gerrit.cloudera.org:8080/#/c/18658/4/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18658/4/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@215
PS4, Line 215: IcebergTable
It's better to use FeIcebergTable, because if local catalog mode is used then this is a LocalIcebergTable. Though I think the contents of the if-stmt could be put at the Catalog-side, where we only have IcebergTable.


http://gerrit.cloudera.org:8080/#/c/18658/4/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:

http://gerrit.cloudera.org:8080/#/c/18658/4/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@194
PS4, Line 194: )
nit: or partitionFields.empty() ?



-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 17:24:55 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................

IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

This commit implements cloning between Iceberg tables. Cloning Iceberg
tables from other Types of tables is not implemented, because the Data
Types of Iceberg and Impala do not correspond one by one.

Testing:
 - e2e tests

Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
---
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
8 files changed, 524 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18658/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10846/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 12:49:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/10871/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Jun 2022 16:55:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 09:57:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................

IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

This commit implements cloning between Iceberg tables. Cloning Iceberg
tables from other Types of tables is not implemented, because the Data
Types of Iceberg and Impala do not correspond one by one.

Testing:
 - e2e tests

Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
---
M docs/topics/impala_iceberg.xml
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
8 files changed, 667 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18658/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8300/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jul 2022 03:14:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................

IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

This commit implements cloning between Iceberg tables. Cloning Iceberg
tables from other Types of tables is not implemented, because the Data
Types of Iceberg and Impala do not correspond one by one.

Testing:
 - e2e tests

Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
---
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
8 files changed, 521 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18658/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................

IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

This commit implements cloning between Iceberg tables. Cloning Iceberg
tables from other Types of tables is not implemented, because the Data
Types of Iceberg and Impala do not correspond one by one.

Testing:
 - e2e tests

Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
7 files changed, 643 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/18658/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 7:

Since the gerrit-code-review-checks task was not triggered, I included the doc related code in another commit


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 04:31:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10942/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 9
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jul 2022 03:34:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10903/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Jun 2022 08:03:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lipenglin@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/18658/4/common/thrift/JniCatalog.thrift
File common/thrift/JniCatalog.thrift:

http://gerrit.cloudera.org:8080/#/c/18658/4/common/thrift/JniCatalog.thrift@514
PS4, Line 514: ameters 
> I think this sholud be optional as we haven't use this field earlier.
Done


http://gerrit.cloudera.org:8080/#/c/18658/4/common/thrift/JniCatalog.thrift@516
PS4, Line 516:   // Fully qualified name of the table to create
             :   1: required CatalogObjects.TTableName table_name
             : 
             :   // List of columns to create
             :   2: required list<CatalogObjects.TColumn> columns
> Can't we retrieve this information at the Catalog side from the source tabl
Done


http://gerrit.cloudera.org:8080/#/c/18658/4/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18658/4/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@215
PS4, Line 215: 
> It's better to use FeIcebergTable, because if local catalog mode is used th
Done


http://gerrit.cloudera.org:8080/#/c/18658/4/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:

http://gerrit.cloudera.org:8080/#/c/18658/4/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@194
PS4, Line 194:  
> nit: or partitionFields.empty() ?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 11:37:18 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10929/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 04:22:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................

IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

This commit implements cloning between Iceberg tables. Cloning Iceberg
tables from other Types of tables is not implemented, because the Data
Types of Iceberg and Impala do not correspond one by one.

Testing:
 - e2e tests

Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Reviewed-on: http://gerrit.cloudera.org:8080/18658
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
7 files changed, 645 insertions(+), 44 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Zoltan Borok-Nagy: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18658 )

Change subject: IMPALA-11287 (part 2): Implement CREATE TABLE LIKE for Iceberg tables
......................................................................


Patch Set 7: Code-Review+2

Thanks for implementing this feature! Looks great!


-- 
To view, visit http://gerrit.cloudera.org:8080/18658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1284b926f51158e221277b18b2e73707e29f86ac
Gerrit-Change-Number: 18658
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jul 2022 09:57:11 +0000
Gerrit-HasComments: No