You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/10/19 21:05:14 UTC

Review Request 63169: Add an example of using the UI plugin mechanism

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63169/
-----------------------------------------------------------

Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.


Repository: aurora


Description
-------

Add an example of using the UI plugin mechanism


Diffs
-----

  build.gradle fa3ed0d88bf6491007eabb2c44dfe78317fd87cf 
  ui/package.json 38950567f1c3259f62bb53352477fb2d429c3276 
  ui/plugin/js/components/Home.js PRE-CREATION 
  ui/plugin/js/components/home.css PRE-CREATION 


Diff: https://reviews.apache.org/r/63169/diff/1/


Testing
-------

./gradlew ui:lint
./gradlew ui:test


Thanks,

David McLaughlin


Re: Review Request 63169: Add an example of using the UI plugin mechanism

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63169/#review188760
-----------------------------------------------------------


Ship it!




Probably rename the `plugin/Home.js` as `plugin/Example.js`.

- Santhosh Kumar Shanmugham


On Oct. 19, 2017, 2:05 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63169/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 2:05 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an example of using the UI plugin mechanism
> 
> 
> Diffs
> -----
> 
>   build.gradle fa3ed0d88bf6491007eabb2c44dfe78317fd87cf 
>   ui/package.json 38950567f1c3259f62bb53352477fb2d429c3276 
>   ui/plugin/js/components/Home.js PRE-CREATION 
>   ui/plugin/js/components/home.css PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63169/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 63169: Add an example of using the UI plugin mechanism

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63169/#review188766
-----------------------------------------------------------


Ship it!




Master (b9ede2f) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 19, 2017, 9:23 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63169/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 9:23 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an example of using the UI plugin mechanism
> 
> 
> Diffs
> -----
> 
>   build.gradle fa3ed0d88bf6491007eabb2c44dfe78317fd87cf 
>   ui/package.json 38950567f1c3259f62bb53352477fb2d429c3276 
>   ui/plugin/js/components/PluginExample.js PRE-CREATION 
>   ui/plugin/js/components/plugin.css PRE-CREATION 
>   ui/src/main/js/components/Home.js 619440f46375eb8e3a32eedcda6f74f3fc58f288 
>   ui/src/main/js/components/PluginExample.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/Home-test.js dde72fc2bad7d7db314191402ab39341ad78cdab 
> 
> 
> Diff: https://reviews.apache.org/r/63169/diff/2/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 63169: Add an example of using the UI plugin mechanism

Posted by David McLaughlin <da...@dmclaughlin.com>.

> On Oct. 20, 2017, 5:07 p.m., Kai Huang wrote:
> > ui/src/main/js/components/PluginExample.js
> > Lines 5 (patched)
> > <https://reviews.apache.org/r/63169/diff/2/?file=1864327#file1864327line5>
> >
> >     OSSPluginExample?

Prepending "OSS" to every component defeats the purpose - only the plugin itself needs to differentiate between its version of PluginExample and the "original" one. In ES6/JavaScript, you can name the default import anything - I chose OSSPluginExample to clarify what I was doing. I could just as easily have written:

    import Anything from '../../../src/main/js/components/PluginExample';


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63169/#review188851
-----------------------------------------------------------


On Oct. 19, 2017, 9:23 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63169/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 9:23 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an example of using the UI plugin mechanism
> 
> 
> Diffs
> -----
> 
>   build.gradle fa3ed0d88bf6491007eabb2c44dfe78317fd87cf 
>   ui/package.json 38950567f1c3259f62bb53352477fb2d429c3276 
>   ui/plugin/js/components/PluginExample.js PRE-CREATION 
>   ui/plugin/js/components/plugin.css PRE-CREATION 
>   ui/src/main/js/components/Home.js 619440f46375eb8e3a32eedcda6f74f3fc58f288 
>   ui/src/main/js/components/PluginExample.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/Home-test.js dde72fc2bad7d7db314191402ab39341ad78cdab 
> 
> 
> Diff: https://reviews.apache.org/r/63169/diff/2/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 63169: Add an example of using the UI plugin mechanism

Posted by Kai Huang <te...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63169/#review188851
-----------------------------------------------------------




ui/src/main/js/components/PluginExample.js
Lines 5 (patched)
<https://reviews.apache.org/r/63169/#comment265842>

    OSSPluginExample?


- Kai Huang


On Oct. 19, 2017, 9:23 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63169/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 9:23 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an example of using the UI plugin mechanism
> 
> 
> Diffs
> -----
> 
>   build.gradle fa3ed0d88bf6491007eabb2c44dfe78317fd87cf 
>   ui/package.json 38950567f1c3259f62bb53352477fb2d429c3276 
>   ui/plugin/js/components/PluginExample.js PRE-CREATION 
>   ui/plugin/js/components/plugin.css PRE-CREATION 
>   ui/src/main/js/components/Home.js 619440f46375eb8e3a32eedcda6f74f3fc58f288 
>   ui/src/main/js/components/PluginExample.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/Home-test.js dde72fc2bad7d7db314191402ab39341ad78cdab 
> 
> 
> Diff: https://reviews.apache.org/r/63169/diff/2/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 63169: Add an example of using the UI plugin mechanism

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63169/
-----------------------------------------------------------

(Updated Oct. 19, 2017, 9:23 p.m.)


Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.


Changes
-------

Home.js -> PluginExample.js


Repository: aurora


Description
-------

Add an example of using the UI plugin mechanism


Diffs (updated)
-----

  build.gradle fa3ed0d88bf6491007eabb2c44dfe78317fd87cf 
  ui/package.json 38950567f1c3259f62bb53352477fb2d429c3276 
  ui/plugin/js/components/PluginExample.js PRE-CREATION 
  ui/plugin/js/components/plugin.css PRE-CREATION 
  ui/src/main/js/components/Home.js 619440f46375eb8e3a32eedcda6f74f3fc58f288 
  ui/src/main/js/components/PluginExample.js PRE-CREATION 
  ui/src/main/js/components/__tests__/Home-test.js dde72fc2bad7d7db314191402ab39341ad78cdab 


Diff: https://reviews.apache.org/r/63169/diff/2/

Changes: https://reviews.apache.org/r/63169/diff/1-2/


Testing
-------

./gradlew ui:lint
./gradlew ui:test


Thanks,

David McLaughlin