You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2024/09/09 11:35:37 UTC
[PR] [SPARK-49534][CORE][FOLLOWUP] Update outdated code comments related to the `AbstractCommandBuilder#isJarAvailable` method [spark]
LuciferYang opened a new pull request, #48032:
URL: https://github.com/apache/spark/pull/48032
### What changes were proposed in this pull request?
This pr just updates the outdated code comments related to the `AbstractCommandBuilder#isJarAvailable` method.
### Why are the changes needed?
Update outdated code comments.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49534][CORE][FOLLOWUP] Update outdated code comments related to the `AbstractCommandBuilder#isJarAvailable` method [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #48032:
URL: https://github.com/apache/spark/pull/48032#discussion_r1750094036
##########
launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java:
##########
@@ -287,10 +287,11 @@ private void addToClassPath(Set<String> cp, String entries) {
}
/**
- * Checks if the spark-hive jar file is available in the specified directory.
+ * Checks if a JAR file with a specific prefix is available in the given directory.
*
- * @param jarsDir the directory to search for spark-hive jar files
- * @return true if a file starting with "spark-hive_" is found, false otherwise
+ * @param jarsDir the directory to search for JAR files
+ * @param jarNamePrefix the prefix of the JAR file name to look for
+ * @return true if a JAR file with the specified prefix is found, false otherwise
Review Comment:
@HyukjinKwon I'm very sorry, I forgot to update the comments for this method before merging.
##########
launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java:
##########
@@ -287,10 +287,11 @@ private void addToClassPath(Set<String> cp, String entries) {
}
/**
- * Checks if the spark-hive jar file is available in the specified directory.
+ * Checks if a JAR file with a specific prefix is available in the given directory.
*
- * @param jarsDir the directory to search for spark-hive jar files
- * @return true if a file starting with "spark-hive_" is found, false otherwise
+ * @param jarsDir the directory to search for JAR files
+ * @param jarNamePrefix the prefix of the JAR file name to look for
+ * @return true if a JAR file with the specified prefix is found, false otherwise
Review Comment:
cc @HyukjinKwon
I'm very sorry, I forgot to update the comments for this method before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49534][CORE][FOLLOWUP] Update outdated code comments related to the `AbstractCommandBuilder#isJarAvailable` method [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #48032: [SPARK-49534][CORE][FOLLOWUP] Update outdated code comments related to the `AbstractCommandBuilder#isJarAvailable` method
URL: https://github.com/apache/spark/pull/48032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49534][CORE][FOLLOWUP] Update outdated code comments related to the `AbstractCommandBuilder#isJarAvailable` method [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #48032:
URL: https://github.com/apache/spark/pull/48032#issuecomment-2338119371
Merged into master. Thanks @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org