[GitHub] [superset] zhangzonghai2021 commented on pull request #23226: Hugh/migrate estimate query cost to v1

["zhangzonghai2021 (via GitHub)" <gi...@apache.org>]

zhangzonghai2021 commented on PR #23226:
URL: https://github.com/apache/superset/pull/23226#issuecomment-1447382672

    unsubscribe.
   
   
   
   ***@***.***
    
   From: Hugh A. Miles II
   Date: 2023-02-28 08:29
   To: apache/superset
   CC: Subscribed
   Subject: [apache/superset] Hugh/migrate estimate query cost to v1 (PR #23226)
   SUMMARY
   BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   TESTING INSTRUCTIONS
   ADDITIONAL INFORMATION
   Has associated issue:
   Required feature flags:
   Changes UI
   Includes DB Migration (follow approval process in SIP-59) 
   Migration is atomic, supports rollback & is backwards-compatible
   Confirm DB migration upgrade and downgrade tested
   Runtime estimates and downtime expectations provided
   Introduces new feature or API
   Removes existing feature or API
   
   
   You can view, comment on, or merge this pull request online at:
     https://github.com/apache/superset/pull/23226
   Commit Summary
   f929d56 chore: Migrate /superset/estimate_query_cost/<database_id>/<schema>/ to API v1
   a4ec247 Merge branch 'master' of github.com:apache/superset into dm/migrate-estimate_query_cost-to-v1
   a7234a8 cleanup
   efc3e0e Merge branch 'master' of github.com:apache/superset into dm/migrate-estimate_query_cost-to-v1
   c660773 PR comments
   File Changes 
   (9 files)
   M docs/static/resources/openapi.json (201) 
   M superset-frontend/src/SqlLab/actions/sqlLab.js (20) 
   M superset-frontend/src/SqlLab/reducers/sqlLab.js (2) 
   M superset/sqllab/api.py (58) 
   A superset/sqllab/commands/estimate.py (106) 
   M superset/sqllab/schemas.py (9) 
   M superset/views/core.py (1) 
   M tests/integration_tests/sql_lab/api_tests.py (67) 
   M tests/integration_tests/sql_lab/commands_tests.py (78) 
   Patch Links:
   https://github.com/apache/superset/pull/23226.patch
   https://github.com/apache/superset/pull/23226.diff
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org