You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/29 05:58:19 UTC
[GitHub] [flink] dianfu opened a new pull request #11556:
[FLINK-16847][python] Support timestamp types in vectorized Python UDF
dianfu opened a new pull request #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556
## What is the purpose of the change
*This pull request adds support of LocalZonedTimestampType and TimestampType in vectorized Python UDF.*
## Brief change log
- *Add support of LocalZonedTimestampType in vectorized Python UDF*
- *Add support of TimestampType in vectorized Python UDF*
## Verifying this change
This change added tests and can be verified as follows:
- *Java tests ArrowUtilsTest, BaseRowArrowReaderWriterTest and RowArrowReaderWriterTest.*
- *Python tests test_pandas_udf.py*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] hequn8128 commented on a change in pull request #11556:
[FLINK-16847][python] Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#discussion_r400002276
##########
File path: flink-python/pyflink/table/types.py
##########
@@ -2282,6 +2288,55 @@ def verify(obj):
return verify
+def to_arrow_type(data_type):
+ """
+ Converts the specified Flink data type to pyarrow data type.
+ """
+ import pyarrow as pa
+ if type(data_type) == TinyIntType:
+ return pa.int8()
+ elif type(data_type) == SmallIntType:
+ return pa.int16()
+ elif type(data_type) == IntType:
+ return pa.int32()
+ elif type(data_type) == BigIntType:
+ return pa.int64()
+ elif type(data_type) == BooleanType:
+ return pa.bool_()
+ elif type(data_type) == FloatType:
+ return pa.float32()
+ elif type(data_type) == DoubleType:
+ return pa.float64()
+ elif type(data_type) == VarCharType:
+ return pa.utf8()
+ elif type(data_type) == VarBinaryType:
+ return pa.binary()
+ elif type(data_type) == DecimalType:
+ return pa.decimal128(data_type.precision, data_type.scale)
+ elif type(data_type) == DateType:
+ return pa.date32()
+ elif type(data_type) == TimeType:
+ if data_type.precision == 0:
+ return pa.time32('s')
+ elif 1 <= data_type.precision <= 3:
+ return pa.time32('ms')
+ elif 4 <= data_type.precision <= 6:
+ return pa.time64('us')
+ else:
+ return pa.time64('ns')
+ elif type(data_type) == LocalZonedTimestampType or type(data_type) == TimestampType:
Review comment:
Maybe `type(data_type) in [LocalZonedTimestampType, TimestampType]:`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11556:
[FLINK-16847][python] Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#issuecomment-605588877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6791",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
}, {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156292914",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
}, {
"hash" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156483574",
"triggerID" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"triggerType" : "PUSH"
}, {
"hash" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6822",
"triggerID" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 523696304fb5cbb20fc334127398571a3bf245ae Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/156292914) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6791)
* 475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/156483574) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6822)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11556: [FLINK-16847][python]
Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#issuecomment-605588877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 523696304fb5cbb20fc334127398571a3bf245ae UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] hequn8128 commented on issue #11556: [FLINK-16847][python]
Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
hequn8128 commented on issue #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#issuecomment-605959054
@dianfu Thanks a lot for the update. LGTM. Merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on a change in pull request #11556:
[FLINK-16847][python] Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#discussion_r400012653
##########
File path: flink-python/pyflink/table/tests/test_pandas_udf.py
##########
@@ -255,7 +276,44 @@ class BlinkBatchPandasUDFITTests(PandasUDFITTests,
class BlinkStreamPandasUDFITTests(PandasUDFITTests,
PyFlinkBlinkStreamTableTestCase):
- pass
+
+ def test_data_types_only_supported_in_blink_planner(self):
Review comment:
Good idea. +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] hequn8128 commented on a change in pull request #11556:
[FLINK-16847][python] Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#discussion_r399968260
##########
File path: flink-python/pyflink/table/tests/test_pandas_udf.py
##########
@@ -255,7 +276,44 @@ class BlinkBatchPandasUDFITTests(PandasUDFITTests,
class BlinkStreamPandasUDFITTests(PandasUDFITTests,
PyFlinkBlinkStreamTableTestCase):
- pass
+
+ def test_data_types_only_supported_in_blink_planner(self):
Review comment:
Extract this `test_data_types_only_supported_in_blink_planner` into a class and make the `BlinkStreamPandasUDFITTests` and `BlinkBatchPandasUDFITTests` extending from this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11556:
[FLINK-16847][python] Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#issuecomment-605588877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6791",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
}, {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156292914",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 523696304fb5cbb20fc334127398571a3bf245ae Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/156292914) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6791)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11556:
[FLINK-16847][python] Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#issuecomment-605588877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6791",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
}, {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156292914",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
}, {
"hash" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156483574",
"triggerID" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"triggerType" : "PUSH"
}, {
"hash" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6822",
"triggerID" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/156483574) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6822)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] hequn8128 commented on a change in pull request #11556:
[FLINK-16847][python] Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#discussion_r400000287
##########
File path: flink-python/pyflink/table/tests/test_pandas_udf.py
##########
@@ -140,6 +142,16 @@ def time_func(time_param):
'time_param of wrong type %s !' % type(time_param[0])
return time_param
+ timestamp_value = datetime.datetime(1970, 1, 1, 0, 0, 0, 123000)
+
+ def timestamp_func(timestamp_param):
+ assert isinstance(timestamp_param, pd.Series)
+ assert isinstance(timestamp_param[0], datetime.datetime), \
+ 'timestamp_param of wrong type %s !' % type(timestamp_param[0])
+ assert timestamp_param[0] == timestamp_value, \
+ 'timestamp_param is wrong value %s, %s!' % (timestamp_param[0], timestamp_value)
Review comment:
How about "timestamp_param is wrong value %s, should be %s!"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11556:
[FLINK-16847][python] Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#issuecomment-605588877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6791",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
}, {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156292914",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 523696304fb5cbb20fc334127398571a3bf245ae Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/156292914) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6791)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11556:
[FLINK-16847][python] Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#issuecomment-605588877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6791",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
}, {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156292914",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
}, {
"hash" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156483574",
"triggerID" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"triggerType" : "PUSH"
}, {
"hash" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6822",
"triggerID" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/156483574) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6822)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] hequn8128 merged pull request #11556: [FLINK-16847][python]
Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
hequn8128 merged pull request #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11556:
[FLINK-16847][python] Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#issuecomment-605588877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6791",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
}, {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156292914",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
}, {
"hash" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 523696304fb5cbb20fc334127398571a3bf245ae Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/156292914) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6791)
* 475f1db8ab2d74e1ff2b19469108d5c9a4a6bb94 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on issue #11556: [FLINK-16847][python]
Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#issuecomment-605861629
@hequn8128 Thanks a lot for the review. The comments make sense to me and have updated the PR according to the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11556:
[FLINK-16847][python] Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#issuecomment-605588877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6791",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
}, {
"hash" : "523696304fb5cbb20fc334127398571a3bf245ae",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156292914",
"triggerID" : "523696304fb5cbb20fc334127398571a3bf245ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 523696304fb5cbb20fc334127398571a3bf245ae Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/156292914) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6791)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11556: [FLINK-16847][python]
Support timestamp types in vectorized Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11556: [FLINK-16847][python] Support timestamp types in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11556#issuecomment-605587957
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 523696304fb5cbb20fc334127398571a3bf245ae (Sun Mar 29 06:00:43 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services