[jira] [Commented] (MYFACES-3871) Problems while loading resources of richfaces 5

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933490#comment-13933490 ] 

Leonardo Uribe commented on MYFACES-3871:
-----------------------------------------

I have debugged the app and the resources are correctly set. But in HtmlStylesheetRenderer there are some lines that prevent to render the same resource twice, that relies on the libraryName and resourceName. The problem is in this line:

            if (ResourceUtils.isRenderedStylesheet(facesContext, resource.getLibraryName(), resource.getResourceName()))
            {
                //Resource already founded
                return;
            }

The libraryName and resourceName are tested again and in this case. URLResource return null for both cases, so the algorithm render the first css but the remaining ones do not. 

There are two options:

1. set the libraryName/resourceName in URLResource (recommended)
2. detect null case and ignore.

Theoretically any Resource instance should provide resourceName and in that sense libraryName too. I have checked the javadoc of Resource and it clearly says:

"... Return the resourceName for this resource. Will never be null. ..."

In that sense I suppose this issue is invalid and should be fixed properly in richfaces.

> Problems while loading resources of richfaces 5
> -----------------------------------------------
>
>                 Key: MYFACES-3871
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3871
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.2.1
>         Environment: tomcat-7.0.50, java 7
>            Reporter: Rene O
>         Attachments: jsftest22.zip, rf5_mojarra.png, rf5_myfaces.png
>
>
> If you use myfaces (2.2.1 or current 2.2.2-SNAPSHOT), Richfaces 5 is not able to load its css-resources correctly.
> If you use current mojarra implementation (2.2.5) all resources load without any complications.
> A testcase (mavenproject) is attached. Within the pom.xml you can change the jsf implementation.
> You can start the testcase with the following URL:
> http://localhost:8080/jsftest22/pages/richfacesskintest.jsf



--
This message was sent by Atlassian JIRA
(v6.2#6252)