You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/14 18:41:59 UTC

[GitHub] [incubator-superset] JMGGarcia opened a new issue #9807: Problems with Public role after updating

JMGGarcia opened a new issue #9807:
URL: https://github.com/apache/incubator-superset/issues/9807


   Hello! I've been running an older version of Superset without a problem, where I embed some dashboards on my website and through the Public user role permissions it is possible to see and use the dashboards. 
   
   However, after updating to version 0.36 (using docker) I've been having problems providing public access to my dashboards. Without changing any user role settings, I get `Access Denied` messages when before I was able to access the dashboard. 
   
   The only way I found around this is to set `PUBLIC_ROLE_LIKE_GAMMA = True` in the `superset_config.py` and then add the necessary permissions. However, every time I restart the server, it overwrites whatever permissions I've added and I have to add them again. If I put this setting back to False again, when I restart, the previous behavior comes up, where the public can't access the dashboard. 
   
   It seems that for some reason Superset doesn't recognize the public user role unless if it is innitiated through the `PUBLIC_ROLE_LIKE_GAMMA` setting. 
   
   Any ideas of what could be done to fix this? Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] dpgaspar commented on issue #9807: Problems with Public role after updating

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #9807:
URL: https://github.com/apache/incubator-superset/issues/9807#issuecomment-680861920


   Hey, 
   
   #10674 fixes this issue, a rerun of `superset init` will keep all data access permissions on the public role. Also introduces a new way of configuring a pre defined public role.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on issue #9807: Problems with Public role after updating

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #9807:
URL: https://github.com/apache/incubator-superset/issues/9807#issuecomment-629031934


   As a workaround, you may be able to set `PUBLIC_ROLE_LIKE_GAMMA = True`, run `superset init`, set `PUBLIC_ROLE_LIKE_GAMMA = False` and then alter Public role.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JMGGarcia commented on issue #9807: Problems with Public role after updating

Posted by GitBox <gi...@apache.org>.
JMGGarcia commented on issue #9807:
URL: https://github.com/apache/incubator-superset/issues/9807#issuecomment-629339570


   I still get the same behavior of not being able to view the public dashboards doing that. Just to be clear, regardless of the user permissions, I still get `Access Denied` when trying to view a public dashboard. So, even though doing what you said did not overwrite the permissions, I still couldn't access the public dashboards (it seems it stops recognizing the public role). 
   
   However, I solved my problem by removing the superset_init container from docker-compose (after the first startup). I'm not sure if this is the intended behavior though... 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on issue #9807: Problems with Public role after updating

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #9807:
URL: https://github.com/apache/incubator-superset/issues/9807#issuecomment-629018180


   Just reproduced this, it appears running `superset init` resets `Public` to be exactly like `Alpha` (removes what was added manually)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] aspedrosa commented on issue #9807: Problems with Public role after updating

Posted by GitBox <gi...@apache.org>.
aspedrosa commented on issue #9807:
URL: https://github.com/apache/incubator-superset/issues/9807#issuecomment-667017034


   Having the same problem
   @mistercrunch @bkyryliuk 
   Shouldn't [this line](https://github.com/apache/incubator-superset/blame/9d9c34835aadfe05d9953611217754e45258ad15/superset/security/manager.py#L405) be
   ```python3
   if conf.get("PUBLIC_ROLE_LIKE_GAMMA", False):
   ```
   or even
   ```python3
   if conf.get("PUBLIC_ROLE_LIKE_GAMMA", False):
       return (
           self.get_session.query(self.role_model)
           .filter_by(name="Gamma")
           .one_or_none()
       )
   ```
   ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] dpgaspar closed issue #9807: Problems with Public role after updating

Posted by GitBox <gi...@apache.org>.
dpgaspar closed issue #9807:
URL: https://github.com/apache/incubator-superset/issues/9807


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org