[GitHub] [hbase] Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode

[GitBox <gi...@apache.org>]

Reidddddd commented on a change in pull request #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528#discussion_r319348246
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
 ##########
 @@ -242,6 +244,11 @@ public int compare(BlockCacheKey a, BlockCacheKey b) {
   /** In-memory bucket size */
   private float memoryFactor;
 
+  private String[] filePaths;
+  static final String FILE_VERIFY_ALGORITHM = "hbase.bucketcache.file.verify.algorithm";
+  static final String DEFAULT_FILE_VERIFY_ALGORITHM = "MD5";
 
 Review comment:
   Set them private, unless you use them somewhere outside package.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services