[GitHub] [drill] agozhiy commented on pull request #2066: DRILL-7705: Updated jQuery and Bootstrap libraries

[GitBox <gi...@apache.org>]

agozhiy commented on pull request #2066:
URL: https://github.com/apache/drill/pull/2066#issuecomment-620813360


   > The Console contains the following errors on all pages
   
   Fixed.
   
   > The text on pages became significantly larger (on all pages), so it breaks the aligning.
   
   Are there any requirements about text size or aligning? I can see line wrappings but all text is visible. On the other hand the text became more comfortable to read.
   
   > On Query page and other pages, Info icon is aligned to the top of the line instead of the center
   
   Fixed by adding drillStyle.css:
   
   ![image](https://user-images.githubusercontent.com/31588230/80527283-cc143000-899c-11ea-95f9-8bf47db02ced.png)
   
   > On the Query result page, aligning of Query profile button and Export button broken. Also added line separator above page.
   
   Fixed by adding mentioned css, also changed the section implementation from table to divs to fix some display issues:
   
   ![image](https://user-images.githubusercontent.com/31588230/80527440-067dcd00-899d-11ea-9a38-16311fc573e3.png)
   
   > On the Query profile page, non-active tabs have the same color as the active one. Also, seen problems with text sizes. Absent the border around Query text field.
   
   Returned default colors, added borders and padding, aligned query field. Tuned the fragments chart height to fully include word "Fragments":
   
   ![image](https://user-images.githubusercontent.com/31588230/80527594-447af100-899d-11ea-8f7f-b814d5299fa3.png)
   
   ![image](https://user-images.githubusercontent.com/31588230/80527649-5fe5fc00-899d-11ea-8200-ba1e9786f43b.png)
   
   ![image](https://user-images.githubusercontent.com/31588230/80527810-a0de1080-899d-11ea-8de6-f9c7bfabb8eb.png)
   
   ![image](https://user-images.githubusercontent.com/31588230/80527913-ccf99180-899d-11ea-9f58-c1ca1d282c3e.png)
   
   ![image](https://user-images.githubusercontent.com/31588230/80527975-e3075200-899d-11ea-91ad-67c71eb04743.png)
   
   > On the Query profiles page, bottom links became black (so it is unclear whether they are clickable). Some text is not bold anymore (f.e. Search Profiles, etc.).
   
   Fixed by updating datatables library:
   
   ![image](https://user-images.githubusercontent.com/31588230/80528266-54df9b80-899e-11ea-8133-3445d8906352.png)
   
   ![image](https://user-images.githubusercontent.com/31588230/80528384-835d7680-899e-11ea-82ea-bdf1fb421279.png)
   
   > On Storage plugins page, in Warning window, the focus is on the close button when it appears. Changed alignment of header.
   
   Fixed:
   
   ![image](https://user-images.githubusercontent.com/31588230/80528980-70977180-899f-11ea-806a-9af9178fedbf.png)
   
   > If the page is scrolled, the navigation bar should be left on the page. For example, the metrics page
   
   Fixed:
   
   ![image](https://user-images.githubusercontent.com/31588230/80529032-8ad14f80-899f-11ea-953b-23594c2d6ddd.png)
   
   > On Logs page also added line separator above the page.
   
   This is a table border and not a line separator.
   
   > Also, please note that before your changes, current page was highlighted with white color, but now only Apache Drill is highlighted.
   
   That is not true, navigation items is only highlighted on mouse hover both before and after the update, though "Apache Drill" is indeed standing out (as intended).
   
   > On the Log page, (last 10,000 lines) has the same size as sqlline.log, but it shouldn't.
   
   Actually, it is smaller )
   
   > Broken aligning on the Options page and something bad happened with a clear field button. Some buttons overlap the options description.
   
   Fixed:
   
   ![image](https://user-images.githubusercontent.com/31588230/80529752-98d3a000-89a0-11ea-894b-364ac833b602.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org