You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/08 07:50:25 UTC

[GitHub] zyt312074545 commented on issue #4351: use enum.Enum to rewrite querystatus

zyt312074545 commented on issue #4351: use enum.Enum to rewrite querystatus
URL: https://github.com/apache/incubator-superset/pull/4351#issuecomment-364029457
 
 
   Sorry, when I see the QueryStatus is Enum-type but it inherited from Object, so I think Enum is better.
   You are right. But useless 'return' needs to be deleted in line 153 in sql_lab.py.
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services