You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/22 15:48:27 UTC
[GitHub] [superset] geido opened a new pull request #12690: fix(explore): Certified metric icons are various sizes
geido opened a new pull request #12690:
URL: https://github.com/apache/superset/pull/12690
### SUMMARY
Closes #12628
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
<img width="641" alt="icon_issue_BEFORE" src="https://user-images.githubusercontent.com/60598000/105512317-3f02cb00-5cd1-11eb-9c80-154421ffccdb.png">
AFTER:
<img width="620" alt="icon_issue_AFTER" src="https://user-images.githubusercontent.com/60598000/105512331-43c77f00-5cd1-11eb-95db-e75c9aa67326.png">
### TEST PLAN
1. Open Explore
2. Setup certified metrics with names of various lengths
3. Make sure the certified icon is of the same size for every metric
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #12628
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12690: fix(explore): Certified metric icons are various sizes
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12690:
URL: https://github.com/apache/superset/pull/12690#issuecomment-765532679
tested manually looks fine 🟢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12690: fix(explore): Certified metric icons are various sizes
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12690:
URL: https://github.com/apache/superset/pull/12690#issuecomment-765689462
<img width="298" alt="Screen Shot 2021-01-22 at 1 17 35 PM" src="https://user-images.githubusercontent.com/67837651/105548237-3cde4380-5cb4-11eb-9cd9-121c097c4eff.png">
LGTM, we may need to look at the label line break separately though.
Thanks for the PR, testing and merging!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #12690: fix(explore): Certified metric icons are various sizes
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #12690:
URL: https://github.com/apache/superset/pull/12690
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org