[GitHub] [sling-org-apache-sling-testing-clients] joerghoh commented on a diff in pull request #41: SLING-11679: Set more descriptive User-Agent for SlingClients

[GitBox <gi...@apache.org>]

joerghoh commented on code in PR #41:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/41#discussion_r1025414048


##########
src/main/java/org/apache/sling/testing/Constants.java:
##########
@@ -37,4 +37,5 @@ public class Constants {
      * Http Context Attributes
      */
     public static final String EXPECTED_STATUS = "expected_status";
+

Review Comment:
   Please remove this unnecessary whitespace-change.



##########
src/main/java/org/apache/sling/testing/clients/SystemPropertiesConfig.java:
##########
@@ -59,6 +61,18 @@ public class SystemPropertiesConfig {
      */
     public static final String HTTP_RETRIES_ERROR_CODES_PROP = "http.retriesErrorCodes";
 
+    /**
+     * System property for {@link SystemPropertiesConfig#getClientUserAgentTitle()}
+     * Prefixed by {@link SystemPropertiesConfig#CONFIG_PROP_PREFIX}
+     */
+    public static final String CLIENT_USERAGENT_TITLE = "client.useragent.title";

Review Comment:
   nitpick: I think that the useragent has a "name", and not a "title" :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org