[GitHub] [pinot] agavra commented on a diff in pull request #9848: support BOOL_AND and BOOL_OR aggregate functions

[GitBox <gi...@apache.org>]

agavra commented on code in PR #9848:
URL: https://github.com/apache/pinot/pull/9848#discussion_r1033928868


##########
pinot-query-runtime/src/test/resources/queries/Aggregates.json:
##########
@@ -164,85 +117,38 @@
         "comments": "class java.lang.Double cannot be cast to class java.lang.Boolean",
         "description": "aggregate boolean column",
         "sql": "SELECT min(bool_col) FROM {tbl}"
+      },
+      {
+        "psql": "9.21.0",
+        "description": "aggregate boolean column",
+        "sql": "SELECT bool_and(bool_col), bool_or(bool_col) FROM {tbl} GROUP BY string_col"
+      },
+      {
+        "psql": "9.21.0",
+        "description": "aggregate boolean column no group by",
+        "sql": "SELECT bool_and(bool_col), bool_or(bool_col) FROM {tbl}"

Review Comment:
   we do not support this yet (for any aggregate function in v2). This is a huge gap, good call out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org