You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/03 08:43:33 UTC

[GitHub] [iotdb] chengjianyun edited a comment on issue #3881: [Cluster-refactor] About refine classes name

chengjianyun edited a comment on issue #3881:
URL: https://github.com/apache/iotdb/issues/3881#issuecomment-912364943


   > Hi, I am almost free now and can find some time back to the development.
   > 
   > 1. Agree to use `*Server`.
   > 2. Agree to move the Thrift interface implementation to  `xx.thrift.impl`,  either using `*Impl` or `*Service` is fine, but considering the server module, I think `*Impl` is more moderate.
   > 3. I hope to rename `MetaGroupMember` to `MetaGroupEngine` and `DataGroupMember` to `DataGroupEngine`.
   
   Welcome back, lol! As I'm working on the refactor client pool part(code compile passed, working on UT fix, latest progress see https://github.com/apache/iotdb/pull/3886), anyone who can help rename the class would be appreciate. But we'd better let the change happen when the refactor almost done to make conflict resolve easier for other contributors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org