You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/08/06 21:04:15 UTC
Re: Review Request 67505: Refactored verify-reviews.py to use
commons.py and argparse.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67505/#review206909
-----------------------------------------------------------
Fix it, then Ship it!
support/python3/verify-reviews.py
Lines 75 (patched)
<https://reviews.apache.org/r/67505/#comment290035>
Pylint tells me that this needs 3 more spaces before `default_query`. The overall style of this call is quite heavy but I don't see how to make things clearer.
support/python3/verify-reviews.py
Line 138 (original), 122 (patched)
<https://reviews.apache.org/r/67505/#comment290036>
A third argument seems to be misssing to call `apply_reviews(review_request, reviews, handler)`.
support/python3/verify-reviews.py
Lines 291 (patched)
<https://reviews.apache.org/r/67505/#comment290037>
A second argument seems to be misssing to call `verify_review(review_request, handler)`.
- Armand Grillet
On July 18, 2018, 8:36 a.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67505/
> -----------------------------------------------------------
>
> (Updated July 18, 2018, 8:36 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored verify-reviews.py to use commons.py and argparse.
>
>
> Diffs
> -----
>
> support/python3/verify-reviews.py 2e925908ffb59dbcdfe99691c5bdbc36a3b7d855
>
>
> Diff: https://reviews.apache.org/r/67505/diff/4/
>
>
> Testing
> -------
>
> Sample run on this review request:
> ```
> ./support/python3/verify-reviews.py -u <user> -p <password> -r 67505 file -o test.txt
>
> 07-18-18_11:09:22 - Running support/python3/verify-reviews.py
> 0 review requests need verification
> ```
>
>
> Thanks,
>
> Dragos Schebesch
>
>