You are viewing a plain text version of this content. The canonical link for it is here.
Posted to svn@forrest.apache.org by gm...@apache.org on 2006/08/20 10:10:52 UTC
svn commit: r432954 - in /forrest/site: live-sites.html live-sites.pdf
Author: gmcdonald
Date: Sun Aug 20 01:10:52 2006
New Revision: 432954
URL: http://svn.apache.org/viewvc?rev=432954&view=rev
Log:
Automatic publish from forrestbot
Modified:
forrest/site/live-sites.html
forrest/site/live-sites.pdf
Modified: forrest/site/live-sites.html
URL: http://svn.apache.org/viewvc/forrest/site/live-sites.html?rev=432954&r1=432953&r2=432954&view=diff
==============================================================================
--- forrest/site/live-sites.html (original)
+++ forrest/site/live-sites.html Sun Aug 20 01:10:52 2006
@@ -544,7 +544,7 @@
<ul>
<li>
-<a href="http://floatingsun.net/">Floating Sun</a>Diwaker Gupta :: Web/Blog/Gallery</li>
+<a href="http://floatingsun.net/">Floating Sun</a> - Diwaker Gupta :: Web/Blog/Gallery</li>
<li>
<a href="http://www.ourlittlestars.org/">Our Little Stars</a> - A non-profit toy library site.
Modified: forrest/site/live-sites.pdf
URL: http://svn.apache.org/viewvc/forrest/site/live-sites.pdf?rev=432954&r1=432953&r2=432954&view=diff
==============================================================================
Binary files - no diff available.
Re: svn commit: r432954 - in /forrest/site: live-sites.html live-sites.pdf
Posted by David Crossley <cr...@apache.org>.
David Crossley wrote:
> Gav.... wrote:
>
> > Question is, do we then close the issue or leave it open seeing as it is
> > A workaround.?
>
> Leave it open. A workaround does not fix it.
I suppose "it depends". Some issues have been marked as
"Resolved Incomplete" but not closed.
-David
Re: svn commit: r432954 - in /forrest/site: live-sites.html live-sites.pdf
Posted by David Crossley <cr...@apache.org>.
Gav.... wrote:
>
> Actually just found http://issues.apache.org/jira/browse/FOR-805 - this
> looks like the same issue to me, I'll link the workaround to this issue.
Can you follow Jean's notes and be sure that it is an
extra carriage-return?
> Question is, do we then close the issue or leave it open seeing as it is
> A workaround.?
Leave it open. A workaround does not fix it.
-David
RE: svn commit: r432954 - in /forrest/site: live-sites.html live-sites.pdf
Posted by "Gav...." <br...@brightontown.com.au>.
> -----Original Message-----
> From: David Crossley [mailto:crossley@apache.org]
> Sent: Wednesday, 23 August 2006 3:51 PM
> To: dev@forrest.apache.org
> Subject: Re: svn commit: r432954 - in /forrest/site: live-sites.html live-
> sites.pdf
>
> Gav.... wrote:
> > > From: David Crossley
> > > Gav.... wrote:
> > > > Incidentally, I changed my site.xml file to read :-
> > > >
> > > > <fixcrlf srcdir="${project.site-dir}" eol="unix">
> > > > <include name="**/*.html"/>
> > > > <include name="**/*.css"/>
> > > > </fixcrlf>
> > > > </then>
> > > > <else>
> > > > <fixcrlf srcdir="${project.site-dir}">
> > > > <include name="**/*.html"/>
> > > > <include name="**/*.css"/>
> > > > </fixcrlf>
> > > >
> > > > So in effect adding *.css to the FOR-492 workaround, shall I commit
> this
> > > do
> > > > you think or will it need further investigation?
> > > >
> > > > As with FOR-492 and problems mentioned there, my builds kept
> putting
> > > ^M
> > > > (CR-LF) on every line of every CSS file causing my build & deploy to
> > > fail.
> > >
> > > Are you sure that this is FOR-492. It seems like something else.
> > > FOR-492 adds mixed line-edings only for processed xml comments.
> > >
> > > If it is different, please add a new Issue. Then yes
> > > apply the workaround, and note the new FOR-#
> >
> > Ok, slightly different problem, same solution, I'll create a new issue.
>
> Good, thanks.
Actually just found http://issues.apache.org/jira/browse/FOR-805 - this
looks like the same issue to me, I'll link the workaround to this issue.
Question is, do we then close the issue or leave it open seeing as it is
A workaround.?
Gav...
>
> > > I keep asking for you to show us the diffs for these
> > > processed CSS files. Is it every line changed? Which files
> > > are changed.
> >
> > I did post some diffs, and at other times just thought that explanations
> > Such as 'every line has a ^M on the end of every CSS file' would
> suffice,
> > I'll undo my fix and send them though if you think you still would like
> to
> > see them.
>
> No, don't bother. Sending a diff to the issue tracker is usually
> much easier than needing to explain in words. Also remember
> that this topic has gone through many email Subject changes,
> so hard to keep track.
>
> > Expanding on that though just in case, all CSS files in the source
> /common/
> > and /pelt/ styles sheets are and were always fine, just when a forrest -
> f
> > publish.xnl build was run, resultant .css files in the build/skin/
> directory
> > all had ^M line endings. Deploying from these of course would copy these
> > over into the /work/skin directory with ^M in them also.
> >
> > > > Adding the above workaround seems to have cured this and the build
> > > directory
> > > > now has proper line endings for the CSS files (In turn therefore the
> > > work
> > > > directory also now has correct line endings).
> > >
> > > Yes, because this is a brute-force approach. The workaround
> > > will work for all kinds of line-endings problems.
> >
> > Are there any negatives to applying this approach ?
>
> It will work. The problem is that it is just covering
> up the real issue. Lets move on, but please add
> the new issue number as as a fixme note next to the
> hack as was done for the other workarounds.
>
> > > > No other files 'seem' to be affected at the moment, but will keep an
> eye
> > > out
> > > > on my Windows system.
> > >
> > > Are you using Cygwin?
> >
> > No, It didn't like my computer and so I had to get rid of it.
>
> That might point to other problems.
>
> > There are plenty of Windows devs in the ASF and they can't all be
> pretending
> > to use linux.
>
> In a previous recent thread about publishing our
> website, Ross said that he did it sucessfully with Windows.
>
> > I Have a linux box with FreeBSD on it, I'll get round to
> > configuring that at some stage I guess, but in the meantime, don't want
> to
> > mess with my production laptop too much.
>
> Forrest should be able to work with any operating system.
>
> Perhaps the type of problems that you have with your system
> are the cause of some of the complaints we have heard about
> Forrest making unnecessary output changes. Grr.
>
> -David
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.405 / Virus Database: 268.11.5/425 - Release Date: 8/22/2006
Re: svn commit: r432954 - in /forrest/site: live-sites.html live-sites.pdf
Posted by David Crossley <cr...@apache.org>.
Gav.... wrote:
> > From: David Crossley
> > Gav.... wrote:
> > > Incidentally, I changed my site.xml file to read :-
> > >
> > > <fixcrlf srcdir="${project.site-dir}" eol="unix">
> > > <include name="**/*.html"/>
> > > <include name="**/*.css"/>
> > > </fixcrlf>
> > > </then>
> > > <else>
> > > <fixcrlf srcdir="${project.site-dir}">
> > > <include name="**/*.html"/>
> > > <include name="**/*.css"/>
> > > </fixcrlf>
> > >
> > > So in effect adding *.css to the FOR-492 workaround, shall I commit this
> > do
> > > you think or will it need further investigation?
> > >
> > > As with FOR-492 and problems mentioned there, my builds kept putting
> > ^M
> > > (CR-LF) on every line of every CSS file causing my build & deploy to
> > fail.
> >
> > Are you sure that this is FOR-492. It seems like something else.
> > FOR-492 adds mixed line-edings only for processed xml comments.
> >
> > If it is different, please add a new Issue. Then yes
> > apply the workaround, and note the new FOR-#
>
> Ok, slightly different problem, same solution, I'll create a new issue.
Good, thanks.
> > I keep asking for you to show us the diffs for these
> > processed CSS files. Is it every line changed? Which files
> > are changed.
>
> I did post some diffs, and at other times just thought that explanations
> Such as 'every line has a ^M on the end of every CSS file' would suffice,
> I'll undo my fix and send them though if you think you still would like to
> see them.
No, don't bother. Sending a diff to the issue tracker is usually
much easier than needing to explain in words. Also remember
that this topic has gone through many email Subject changes,
so hard to keep track.
> Expanding on that though just in case, all CSS files in the source /common/
> and /pelt/ styles sheets are and were always fine, just when a forrest -f
> publish.xnl build was run, resultant .css files in the build/skin/ directory
> all had ^M line endings. Deploying from these of course would copy these
> over into the /work/skin directory with ^M in them also.
>
> > > Adding the above workaround seems to have cured this and the build
> > directory
> > > now has proper line endings for the CSS files (In turn therefore the
> > work
> > > directory also now has correct line endings).
> >
> > Yes, because this is a brute-force approach. The workaround
> > will work for all kinds of line-endings problems.
>
> Are there any negatives to applying this approach ?
It will work. The problem is that it is just covering
up the real issue. Lets move on, but please add
the new issue number as as a fixme note next to the
hack as was done for the other workarounds.
> > > No other files 'seem' to be affected at the moment, but will keep an eye
> > out
> > > on my Windows system.
> >
> > Are you using Cygwin?
>
> No, It didn't like my computer and so I had to get rid of it.
That might point to other problems.
> There are plenty of Windows devs in the ASF and they can't all be pretending
> to use linux.
In a previous recent thread about publishing our
website, Ross said that he did it sucessfully with Windows.
> I Have a linux box with FreeBSD on it, I'll get round to
> configuring that at some stage I guess, but in the meantime, don't want to
> mess with my production laptop too much.
Forrest should be able to work with any operating system.
Perhaps the type of problems that you have with your system
are the cause of some of the complaints we have heard about
Forrest making unnecessary output changes. Grr.
-David
RE: svn commit: r432954 - in /forrest/site: live-sites.html live-sites.pdf
Posted by "Gav...." <br...@brightontown.com.au>.
> -----Original Message-----
> From: David Crossley [mailto:crossley@apache.org]
> Sent: Monday, 21 August 2006 11:53 AM
> To: dev@forrest.apache.org
> Subject: Re: svn commit: r432954 - in /forrest/site: live-sites.html live-
> sites.pdf
>
> Gav.... wrote:
> > Incidentally, I changed my site.xml file to read :-
> >
> > <fixcrlf srcdir="${project.site-dir}" eol="unix">
> > <include name="**/*.html"/>
> > <include name="**/*.css"/>
> > </fixcrlf>
> > </then>
> > <else>
> > <fixcrlf srcdir="${project.site-dir}">
> > <include name="**/*.html"/>
> > <include name="**/*.css"/>
> > </fixcrlf>
> >
> > So in effect adding *.css to the FOR-492 workaround, shall I commit this
> do
> > you think or will it need further investigation?
> >
> > As with FOR-492 and problems mentioned there, my builds kept putting
> ^M
> > (CR-LF) on every line of every CSS file causing my build & deploy to
> fail.
>
> Are you sure that this is FOR-492. It seems like something else.
> FOR-492 adds mixed line-edings only for processed xml comments.
>
> If it is different, please add a new Issue. Then yes
> apply the workaround, and note the new FOR-#
Ok, slightly different problem, same solution, I'll create a new issue.
>
> I keep asking for you to show us the diffs for these
> processed CSS files. Is it every line changed? Which files
> are changed.
I did post some diffs, and at other times just thought that explanations
Such as 'every line has a ^M on the end of every CSS file' would suffice,
I'll undo my fix and send them though if you think you still would like to
see them.
Expanding on that though just in case, all CSS files in the source /common/
and /pelt/ styles sheets are and were always fine, just when a forrest -f
publish.xnl build was run, resultant .css files in the build/skin/ directory
all had ^M line endings. Deploying from these of course would copy these
over into the /work/skin directory with ^M in them also.
>
> > Adding the above workaround seems to have cured this and the build
> directory
> > now has proper line endings for the CSS files (In turn therefore the
> work
> > directory also now has correct line endings).
>
> Yes, because this is a brute-force approach. The workaround
> will work for all kinds of line-endings problems.
Are there any negatives to applying this approach ?
>
> > No other files 'seem' to be affected at the moment, but will keep an eye
> out
> > on my Windows system.
>
> Are you using Cygwin?
No, It didn't like my computer and so I had to get rid of it.
There are plenty of Windows devs in the ASF and they can't all be pretending
to use linux. I Have a linux box with FreeBSD on it, I'll get round to
configuring that at some stage I guess, but in the meantime, don't want to
mess with my production laptop too much.
Gav...
>
> -David
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.405 / Virus Database: 268.11.3/423 - Release Date: 8/18/2006
Re: svn commit: r432954 - in /forrest/site: live-sites.html live-sites.pdf
Posted by David Crossley <cr...@apache.org>.
Gav.... wrote:
> Incidentally, I changed my site.xml file to read :-
>
> <fixcrlf srcdir="${project.site-dir}" eol="unix">
> <include name="**/*.html"/>
> <include name="**/*.css"/>
> </fixcrlf>
> </then>
> <else>
> <fixcrlf srcdir="${project.site-dir}">
> <include name="**/*.html"/>
> <include name="**/*.css"/>
> </fixcrlf>
>
> So in effect adding *.css to the FOR-492 workaround, shall I commit this do
> you think or will it need further investigation?
>
> As with FOR-492 and problems mentioned there, my builds kept putting ^M
> (CR-LF) on every line of every CSS file causing my build & deploy to fail.
Are you sure that this is FOR-492. It seems like something else.
FOR-492 adds mixed line-edings only for processed xml comments.
If it is different, please add a new Issue. Then yes
apply the workaround, and note the new FOR-#
I keep asking for you to show us the diffs for these
processed CSS files. Is it every line changed? Which files
are changed.
> Adding the above workaround seems to have cured this and the build directory
> now has proper line endings for the CSS files (In turn therefore the work
> directory also now has correct line endings).
Yes, because this is a brute-force approach. The workaround
will work for all kinds of line-endings problems.
> No other files 'seem' to be affected at the moment, but will keep an eye out
> on my Windows system.
Are you using Cygwin?
-David
RE: svn commit: r432954 - in /forrest/site: live-sites.html live-sites.pdf
Posted by "Gav...." <br...@brightontown.com.au>.
Incidentally, I changed my site.xml file to read :-
<fixcrlf srcdir="${project.site-dir}" eol="unix">
<include name="**/*.html"/>
<include name="**/*.css"/>
</fixcrlf>
</then>
<else>
<fixcrlf srcdir="${project.site-dir}">
<include name="**/*.html"/>
<include name="**/*.css"/>
</fixcrlf>
So in effect adding *.css to the FOR-492 workaround, shall I commit this do
you think or will it need further investigation?
As with FOR-492 and problems mentioned there, my builds kept putting ^M
(CR-LF) on every line of every CSS file causing my build & deploy to fail.
Adding the above workaround seems to have cured this and the build directory
now has proper line endings for the CSS files (In turn therefore the work
directory also now has correct line endings).
No other files 'seem' to be affected at the moment, but will keep an eye out
on my Windows system.
Gav...
> -----Original Message-----
> From: Gav.... [mailto:brightoncomputers@brightontown.com.au]
> Sent: Sunday, 20 August 2006 4:16 PM
> To: 'Forrest Developers List'
> Subject: RE: svn commit: r432954 - in /forrest/site: live-sites.html live-
> sites.pdf
>
> This looks more promising; I'll leave it now and see if others can spot
> potential problems.
>
> Gav...
>
>
> > -----Original Message-----
> > From: gmcdonald@apache.org [mailto:gmcdonald@apache.org]
> > Sent: Sunday, 20 August 2006 4:11 PM
> > To: svn@forrest.apache.org
> > Subject: svn commit: r432954 - in /forrest/site: live-sites.html live-
> > sites.pdf
> >
> > Author: gmcdonald
> > Date: Sun Aug 20 01:10:52 2006
> > New Revision: 432954
> >
> > URL: http://svn.apache.org/viewvc?rev=432954&view=rev
> > Log:
> > Automatic publish from forrestbot
> >
> > Modified:
> > forrest/site/live-sites.html
> > forrest/site/live-sites.pdf
> >
> > Modified: forrest/site/live-sites.html
> > URL: http://svn.apache.org/viewvc/forrest/site/live-
> > sites.html?rev=432954&r1=432953&r2=432954&view=diff
> >
> ==========================================================================
> > ====
> > --- forrest/site/live-sites.html (original)
> > +++ forrest/site/live-sites.html Sun Aug 20 01:10:52 2006
> > @@ -544,7 +544,7 @@
> > <ul>
> >
> > <li>
> > -<a href="http://floatingsun.net/">Floating Sun</a>Diwaker Gupta ::
> > Web/Blog/Gallery</li>
> > +<a href="http://floatingsun.net/">Floating Sun</a> - Diwaker Gupta ::
> > Web/Blog/Gallery</li>
> >
> > <li>
> > <a href="http://www.ourlittlestars.org/">Our Little Stars</a> - A non-
> > profit toy library site.
> >
> > Modified: forrest/site/live-sites.pdf
> > URL: http://svn.apache.org/viewvc/forrest/site/live-
> > sites.pdf?rev=432954&r1=432953&r2=432954&view=diff
> >
> ==========================================================================
> > ====
> > Binary files - no diff available.
> >
> >
> >
> >
> > --
> > No virus found in this incoming message.
> > Checked by AVG Free Edition.
> > Version: 7.1.405 / Virus Database: 268.11.3/423 - Release Date:
> 8/18/2006
>
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.405 / Virus Database: 268.11.3/423 - Release Date: 8/18/2006
RE: svn commit: r432954 - in /forrest/site: live-sites.html live-sites.pdf
Posted by "Gav...." <br...@brightontown.com.au>.
This looks more promising; I'll leave it now and see if others can spot
potential problems.
Gav...
> -----Original Message-----
> From: gmcdonald@apache.org [mailto:gmcdonald@apache.org]
> Sent: Sunday, 20 August 2006 4:11 PM
> To: svn@forrest.apache.org
> Subject: svn commit: r432954 - in /forrest/site: live-sites.html live-
> sites.pdf
>
> Author: gmcdonald
> Date: Sun Aug 20 01:10:52 2006
> New Revision: 432954
>
> URL: http://svn.apache.org/viewvc?rev=432954&view=rev
> Log:
> Automatic publish from forrestbot
>
> Modified:
> forrest/site/live-sites.html
> forrest/site/live-sites.pdf
>
> Modified: forrest/site/live-sites.html
> URL: http://svn.apache.org/viewvc/forrest/site/live-
> sites.html?rev=432954&r1=432953&r2=432954&view=diff
> ==========================================================================
> ====
> --- forrest/site/live-sites.html (original)
> +++ forrest/site/live-sites.html Sun Aug 20 01:10:52 2006
> @@ -544,7 +544,7 @@
> <ul>
>
> <li>
> -<a href="http://floatingsun.net/">Floating Sun</a>Diwaker Gupta ::
> Web/Blog/Gallery</li>
> +<a href="http://floatingsun.net/">Floating Sun</a> - Diwaker Gupta ::
> Web/Blog/Gallery</li>
>
> <li>
> <a href="http://www.ourlittlestars.org/">Our Little Stars</a> - A non-
> profit toy library site.
>
> Modified: forrest/site/live-sites.pdf
> URL: http://svn.apache.org/viewvc/forrest/site/live-
> sites.pdf?rev=432954&r1=432953&r2=432954&view=diff
> ==========================================================================
> ====
> Binary files - no diff available.
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.405 / Virus Database: 268.11.3/423 - Release Date: 8/18/2006