You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/09/30 06:52:33 UTC
[jira] Created: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
skip corrupt rows during compaction instead of erroring out and aborting
------------------------------------------------------------------------
Key: CASSANDRA-466
URL: https://issues.apache.org/jira/browse/CASSANDRA-466
Project: Cassandra
Issue Type: Sub-task
Components: Core
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Fix For: 0.5
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-466) skip corrupt rows during
compaction instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768387#action_12768387 ]
Jonathan Ellis commented on CASSANDRA-466:
------------------------------------------
new rule of thumb: if an error is recoverable, propagate that up through the method with "throws IOException." otherwise wrap it as a RuntimeException. this primarily distinguishes error-on-read (which may be recoverable) from error-on-write (give up, you're screwed).
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: 0002-add-checks-for-obviously-bogus-values-read.txt
0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-466) skip corrupt rows during
compaction instead of erroring out and aborting
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768968#action_12768968 ]
Jun Rao commented on CASSANDRA-466:
-----------------------------------
+1
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-466) skip corrupt rows during
compaction instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761734#action_12761734 ]
Jonathan Ellis commented on CASSANDRA-466:
------------------------------------------
applied 0.4 executor and (part of) logging patches, after testing by Anthony Molinaro on irc, and added some more asserts. That's about as much as we can usefully do on 0.4; even the row size seems to occasionally be bogus (saw reads of 0) which this doesn't help with. IMO it's not worth the code churn in a release branch to have a partial fix like that.
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-minor-fixes.txt, 0002-make-compaction-more-bulletproof.txt, 0003-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: 466-0-4.patch
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-minor-fixes.txt, 0002-make-compaction-more-bulletproof.txt, 0003-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-466) skip corrupt rows during
compaction instead of erroring out and aborting
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768729#action_12768729 ]
Jun Rao commented on CASSANDRA-466:
-----------------------------------
The patch failed the following junit test.
[junit] Testcase: testMakeReadMessage(org.apache.cassandra.db.ReadMessageTest): FAILED
[junit] null
[junit] junit.framework.AssertionFailedError
[junit] at org.apache.cassandra.db.ColumnSerializer.writeName(ColumnSerializer.java:34)
[junit] at org.apache.cassandra.db.filter.QueryPath.serialize(QueryPath.java:88)
[junit] at org.apache.cassandra.db.SliceByNamesReadCommandSerializer.serialize(SliceByNamesReadCommand.java:81)
[junit] at org.apache.cassandra.db.ReadCommandSerializer.serialize(ReadCommand.java:112)
[junit] at org.apache.cassandra.db.ReadMessageTest.serializeAndDeserializeReadMessage(ReadMessageTest.java:66)
[junit] at org.apache.cassandra.db.ReadMessageTest.testMakeReadMessage(ReadMessageTest.java:48)
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-466) skip corrupt rows during
compaction instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771010#action_12771010 ]
Jonathan Ellis commented on CASSANDRA-466:
------------------------------------------
No. Compaction was rewritten for 0.5 in CASSANDRA-436; backporting that (or 466 without 436) is outside the scope of a "stable" branch.
What you can do in 0.4 is add <SnapshotBeforeCompaction>true</SnapshotBeforeCompaction> and it will preserve the original version of all sstables indefinitely, so if a corruption is introduced you can go back to the originals and file a bug report. :)
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: (was: 0002-make-compaction-more-bulletproof.txt)
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: (was: 0003-add-checks-for-obviously-bogus-values-read.txt)
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: 466-0-4-executor.patch
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-minor-fixes.txt, 0002-make-compaction-more-bulletproof.txt, 0003-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: 466-0-4.patch
new version, should fix better
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-minor-fixes.txt, 0002-make-compaction-more-bulletproof.txt, 0003-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: 0002-add-checks-for-obviously-bogus-values-read.txt
0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: (was: 466-0-4.patch)
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-minor-fixes.txt, 0002-make-compaction-more-bulletproof.txt, 0003-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-466) skip corrupt rows during
compaction instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768785#action_12768785 ]
Jonathan Ellis commented on CASSANDRA-466:
------------------------------------------
fixed & rebased
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: 0003-add-checks-for-obviously-bogus-values-read.txt
0002-make-compaction-more-bulletproof.txt
0001-CASSANDRA-466-minor-fixes.txt
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-minor-fixes.txt, 0002-make-compaction-more-bulletproof.txt, 0003-add-checks-for-obviously-bogus-values-read.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: 466-0-4-logging.patch
extra logging for compaction on 0.4 branch
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-minor-fixes.txt, 0002-make-compaction-more-bulletproof.txt, 0003-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: 466-0-4.patch
Here is a patch that applies to branches/cassandra-0.4.
Note that you should snapshot your sstables before applying patches (like these) that mess with the compaction code. Just in case. :)
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-minor-fixes.txt, 0002-make-compaction-more-bulletproof.txt, 0003-add-checks-for-obviously-bogus-values-read.txt, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: 466-0-4.patch
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-minor-fixes.txt, 0002-make-compaction-more-bulletproof.txt, 0003-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch, 466-0-4.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-466) skip corrupt rows during
compaction instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768384#action_12768384 ]
Jonathan Ellis commented on CASSANDRA-466:
------------------------------------------
Rebased patches 01 and 02 that catch column-based corruption and skip it.
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-466) skip corrupt rows during
compaction instead of erroring out and aborting
Posted by "Ryan King (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770988#action_12770988 ]
Ryan King commented on CASSANDRA-466:
-------------------------------------
Will this be applied to the 0.4 branch?
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-466) skip corrupt rows during compaction
instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-466:
-------------------------------------
Attachment: (was: 0001-CASSANDRA-466-minor-fixes.txt)
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-466) skip corrupt rows during
compaction instead of erroring out and aborting
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-466.
--------------------------------------
Resolution: Fixed
committed
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-466) skip corrupt rows during
compaction instead of erroring out and aborting
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769204#action_12769204 ]
Hudson commented on CASSANDRA-466:
----------------------------------
Integrated in Cassandra #236 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/236/])
add checks for obviously bogus values read
patch by jbellis; reviewed by junrao for
make compaction able to recover from errors w/in a row
patch by jbellis; reviewed by junrao for
> skip corrupt rows during compaction instead of erroring out and aborting
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-466
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.5
>
> Attachments: 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0001-CASSANDRA-466-make-compaction-able-to-recover-from-err.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 0002-add-checks-for-obviously-bogus-values-read.txt, 466-0-4-executor.patch, 466-0-4-logging.patch, 466-0-4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.