You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/22 09:06:11 UTC

[GitHub] [netbeans] sdedic edited a comment on pull request #2731: Support for VM/app argument injection to (maven) run and debug project actions

sdedic edited a comment on pull request #2731:
URL: https://github.com/apache/netbeans/pull/2731#issuecomment-781140970


   @entlicher I've joined the 2 impls of `PropertySplitter` in the `runjar` package (`customizer` pkg already depended on `runjar`, not the other way around). 
   During that, I've noticed dead code in `RunJarPanel` (and a little in `MavenExecuteUtils`) and deleted it - results in moving the only tests for `RunJarPanel` which actually tested parameter splitting now done by `MavenExecuteUtils`.
   
   Please re-review commit 50ee5d6


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists