You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Bastian Hofmann (JIRA)" <ji...@apache.org> on 2010/07/15 13:27:50 UTC
[jira] Created: (SHINDIG-1387) Signature of getSecurityToken in
BasicOAuthLookupService does not match base class OAuthLookupService
Signature of getSecurityToken in BasicOAuthLookupService does not match base class OAuthLookupService
-----------------------------------------------------------------------------------------------------
Key: SHINDIG-1387
URL: https://issues.apache.org/jira/browse/SHINDIG-1387
Project: Shindig
Issue Type: Bug
Reporter: Bastian Hofmann
Patch:
Index: php/src/common/sample/BasicOAuthLookupService.php
===================================================================
27c27
< public function getSecurityToken($oauthRequest, $appUrl, $userId) {
---
> public function getSecurityToken($oauthRequest, $appUrl, $userId, $contentType) {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1387) Signature of getSecurityToken in
BasicOAuthLookupService does not match base class OAuthLookupService
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1387.
-----------------------------------
Resolution: Fixed
fixed.
> Signature of getSecurityToken in BasicOAuthLookupService does not match base class OAuthLookupService
> -----------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1387
> URL: https://issues.apache.org/jira/browse/SHINDIG-1387
> Project: Shindig
> Issue Type: Bug
> Reporter: Bastian Hofmann
> Fix For: 2.0.0-RC1
>
>
> Patch:
> Index: php/src/common/sample/BasicOAuthLookupService.php
> ===================================================================
> 27c27
> < public function getSecurityToken($oauthRequest, $appUrl, $userId) {
> ---
> > public function getSecurityToken($oauthRequest, $appUrl, $userId, $contentType) {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1387) Signature of getSecurityToken in
BasicOAuthLookupService does not match base class OAuthLookupService
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888804#action_12888804 ]
Paul Lindner commented on SHINDIG-1387:
---------------------------------------
ah, you had a reverse patch there.. so the solution is to remove the contentType from the signature?
> Signature of getSecurityToken in BasicOAuthLookupService does not match base class OAuthLookupService
> -----------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1387
> URL: https://issues.apache.org/jira/browse/SHINDIG-1387
> Project: Shindig
> Issue Type: Bug
> Reporter: Bastian Hofmann
> Fix For: 2.0.0-RC1
>
>
> Patch:
> Index: php/src/common/sample/BasicOAuthLookupService.php
> ===================================================================
> 27c27
> < public function getSecurityToken($oauthRequest, $appUrl, $userId) {
> ---
> > public function getSecurityToken($oauthRequest, $appUrl, $userId, $contentType) {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1387) Signature of getSecurityToken in
BasicOAuthLookupService does not match base class OAuthLookupService
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1387.
-----------------------------------
Fix Version/s: 2.0.0-RC1
Resolution: Invalid
already in trunk:
commit f95a63362501599ef51afdb2170124eec0d125d6
Author: Chris Chabot <ch...@apache.org>
Date: Mon Apr 6 18:47:00 2009 +0000
Re-enables the exception on unsupported content-type and adds the content-type to the oauth lookup service call
git-svn-id: https://svn.apache.org/repos/asf/incubator/shindig/trunk@762451 13f79535-47bb-0310-9956-ffa450edef68
> Signature of getSecurityToken in BasicOAuthLookupService does not match base class OAuthLookupService
> -----------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1387
> URL: https://issues.apache.org/jira/browse/SHINDIG-1387
> Project: Shindig
> Issue Type: Bug
> Reporter: Bastian Hofmann
> Fix For: 2.0.0-RC1
>
>
> Patch:
> Index: php/src/common/sample/BasicOAuthLookupService.php
> ===================================================================
> 27c27
> < public function getSecurityToken($oauthRequest, $appUrl, $userId) {
> ---
> > public function getSecurityToken($oauthRequest, $appUrl, $userId, $contentType) {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SHINDIG-1387) Signature of getSecurityToken in
BasicOAuthLookupService does not match base class OAuthLookupService
Posted by "Bastian Hofmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bastian Hofmann reopened SHINDIG-1387:
--------------------------------------
If I have a look into the current trunk the BasicOAuthLookupService still is wrong:
/**
* Basic implementation of OAuthLookupService using BasicOAuthDataStore.
*/
class BasicOAuthLookupService extends OAuthLookupService {
public function getSecurityToken($oauthRequest, $appUrl, $userId) {
return new OAuthSecurityToken($userId, $appUrl, $this->getAppId($appUrl), "samplecontainer");
}
private function getAppId($appUrl) {
return 0; // a real implementation would look this up
}
}
https://svn.apache.org/repos/asf/shindig/trunk/php/src/common/sample/BasicOAuthLookupService.php
> Signature of getSecurityToken in BasicOAuthLookupService does not match base class OAuthLookupService
> -----------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1387
> URL: https://issues.apache.org/jira/browse/SHINDIG-1387
> Project: Shindig
> Issue Type: Bug
> Reporter: Bastian Hofmann
> Fix For: 2.0.0-RC1
>
>
> Patch:
> Index: php/src/common/sample/BasicOAuthLookupService.php
> ===================================================================
> 27c27
> < public function getSecurityToken($oauthRequest, $appUrl, $userId) {
> ---
> > public function getSecurityToken($oauthRequest, $appUrl, $userId, $contentType) {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1387) Signature of getSecurityToken in
BasicOAuthLookupService does not match base class OAuthLookupService
Posted by "Bastian Hofmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888808#action_12888808 ]
Bastian Hofmann commented on SHINDIG-1387:
------------------------------------------
https://svn.apache.org/repos/asf/shindig/trunk/php/src/common/OAuthLookupService.php
has the $contenType parameter
https://svn.apache.org/repos/asf/shindig/trunk/php/src/common/sample/BasicOAuthLookupService.php
hasn't
if i understand chris' commit message correctly and if you look in the ApiServlet which uses the LookupService you see that it is used like this:
$oauthLookupService = Config::get('oauth_lookup_service');
$oauthLookupService = new $oauthLookupService();
$token = $oauthLookupService->getSecurityToken($request, $appUrl, $userId, $this->getContentType());
So that means the $contentType parameter should be added to the BasicOAuthLookupService as well
https://svn.apache.org/repos/asf/shindig/trunk/php/src/social/servlet/ApiServlet.php
> Signature of getSecurityToken in BasicOAuthLookupService does not match base class OAuthLookupService
> -----------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1387
> URL: https://issues.apache.org/jira/browse/SHINDIG-1387
> Project: Shindig
> Issue Type: Bug
> Reporter: Bastian Hofmann
> Fix For: 2.0.0-RC1
>
>
> Patch:
> Index: php/src/common/sample/BasicOAuthLookupService.php
> ===================================================================
> 27c27
> < public function getSecurityToken($oauthRequest, $appUrl, $userId) {
> ---
> > public function getSecurityToken($oauthRequest, $appUrl, $userId, $contentType) {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.