You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by vieiro <gi...@git.apache.org> on 2017/10/03 21:05:33 UTC
[GitHub] incubator-netbeans pull request #53: [NETBEANS-54] Module Review editor.code...
GitHub user vieiro opened a pull request:
https://github.com/apache/incubator-netbeans/pull/53
[NETBEANS-54] Module Review editor.codetemplates
* No external libraries.
* A nbproject/*sig that will be handled centrally.
* Some text xml files wihout license header.
* Test org.netbeans.lib.editor.codetemplates.CodeTemplatesTest FAILED...
... but ant -Dtest-unit-sys-prop.ignore.random.failures=true test did not fail.
* Did you know that NetBeans DeveloperX2 was released in the spring of 1998?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vieiro/incubator-netbeans netbeans-54-module-review-editor.codetemplates
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit da1da87d7f2bf5a7183a4f5d703cab1311c46040
Author: Antonio Vieiro <an...@vieiro.net>
Date: 2017-10-03T20:48:49Z
[NETBEANS-54] Module Review editor.codetemplates
* No external libraries.
* A nbproject/*sig that will be handled centrally.
* Some text xml files wihout license header.
* Test org.netbeans.lib.editor.codetemplates.CodeTemplatesTest FAILED...
... but ant -Dtest-unit-sys-prop.ignore.random.failures=true test did not fail.
* Did you know that NetBeans DeveloperX2 was released in the spring of 1998?
----
---
[GitHub] incubator-netbeans issue #53: [NETBEANS-54] Module Review editor.codetemplat...
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/53
Could you please revisit the "some text xml files without header". If possible I'd add a license header, if not, I'd add an exclude to build.xml.
---
[GitHub] incubator-netbeans pull request #53: [NETBEANS-54] Module Review editor.code...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/53
---
[GitHub] incubator-netbeans issue #53: [NETBEANS-54] Module Review editor.codetemplat...
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/53
Merged - thank you!
---