You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/09/04 10:03:31 UTC

[GitHub] [tinkerpop] danielcweber commented on issue #1115: Alternative approach to TINKERPOP-2217.

danielcweber commented on issue #1115: Alternative approach to TINKERPOP-2217. 
URL: https://github.com/apache/tinkerpop/pull/1115#issuecomment-527834051
 
 
   The improvement in my patch is that it achieves what the original code did (queueing up items asynchronously), but by means of a higher level construct (SemaphoreSlim vs. combination of queues, CAS, etc.). I found the original code hard to reason about, as lock-free code usually is. [My original workaround](https://github.com/apache/tinkerpop/pull/1114) already fixed a bug that had slipped through unnoticed for quite some time.
   
   Yes, SemaphoreSlim does contain a synchrounous lock, but I don't see that this is a problem per se. The driver as a whole is not designed to be lock-free in every part, which is usually just fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services