[GitHub] [ozone] kerneltime commented on a diff in pull request #3297: HDDS-4440. HDDS-4440-s3-performance branch Merge to Master PR - draft

[GitBox <gi...@apache.org>]

kerneltime commented on code in PR #3297:
URL: https://github.com/apache/ozone/pull/3297#discussion_r851894860


##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1354,9 +1354,9 @@ message UpdateGetS3SecretRequest {
   This will be used by OM to authenticate S3 gateway requests on a per request basis.
 */
 message S3Authentication {
-    optional string stringToSign = 1;
-    optional string signature = 2;
-    optional string accessId = 3;
+    required string stringToSign = 1;
+    required string signature = 2;
+    required string accessId = 3;

Review Comment:
   We should keep these as optional. Any error handling should be at the higher layer where the request is processed. Here the validation will fail if set incorrectly in a secure cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org