[GitHub] [beam] kw2542 commented on a change in pull request #14942: [BEAM-8137] Add Main method to ExternalWorkerService

[GitBox <gi...@apache.org>]

kw2542 commented on a change in pull request #14942:
URL: https://github.com/apache/beam/pull/14942#discussion_r646786141



##########
File path: runners/portability/java/src/main/java/org/apache/beam/runners/portability/ExternalWorkerService.java
##########
@@ -90,10 +97,44 @@ public void stopWorker(
   public void close() {}
 
   public GrpcFnServer<ExternalWorkerService> start() throws Exception {
-    GrpcFnServer<ExternalWorkerService> server =
-        GrpcFnServer.allocatePortAndCreateFor(this, serverFactory);
+    final String externalServiceAddress =
+        Environments.getExternalServiceAddress(options.as(PortablePipelineOptions.class));
+    GrpcFnServer<ExternalWorkerService> server;
+    if (externalServiceAddress.isEmpty()) {
+      server = GrpcFnServer.allocatePortAndCreateFor(this, serverFactory);
+    } else {
+      server =
+          GrpcFnServer.create(
+              this,
+              Endpoints.ApiServiceDescriptor.newBuilder().setUrl(externalServiceAddress).build(),
+              serverFactory);
+    }
     LOG.debug(
         "Listening for worker start requests at {}.", server.getApiServiceDescriptor().getUrl());
     return server;
   }
+
+  public static void main(String[] args) throws Exception {

Review comment:
       Got you, I will update the javadoc.
   
   In addition, I am planning to have a separate PR out to update the `java/container/boot.go` to accept `worker_pool` option, just like `python/container/boot.go` so that `boot.go` can start `ExternalWorkerService` instead of `FnHarness` like `java -cp xxx org.apache.beam.runners.portability.ExternalWorkerService` 
   
   Do you think this aligns your thoughts on how java should support worker pool ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org