You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/03/30 20:48:22 UTC
[GitHub] [incubator-yunikorn-k8shim] yangwwei edited a comment on issue #90:
[YUNIKORN-44] Pass scheduler startup options from environment variables
yangwwei edited a comment on issue #90: [YUNIKORN-44] Pass scheduler startup options from environment variables
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/90#issuecomment-606239758
Hi @kingamarton
Thanks for the updates, it looks good. I have tested and it works as expected.
Can I ask one more thing for this PR? Sorry I did not mention this earlier
In `pkg/conf/schedulerconf.go`, there are a lot more configurable options. Ideally, we need them all in the dockerfile, giving a default value. So this gives us enough flexibility not to go back and modify the dockerfile again if we want to tweak some changes in the future. I think we need to add following (just excluded one or two no need for updates)
```
ENV CLUSTER_ID "mycluster"
ENV CLUSTER_VERSION "latest"
ENV LOG_ENCODING "console"
ENV LOG_LEVEL "-1"
ENV SCHEDULER_NAME "yunikorn"
ENV POLICY_GROUP "queues"
ENV SCHEDULING_INTERVAL "0"
ENV VOLUME_BINDING_TIMEOUT "10s"
ENV KUBE_CLIENT_QPS "1000"
ENV KUBE_CLIENT_BURST "1000"
ENV EVENT_CHANNEL_CAPACITY "1048576"
ENV DISPATCHER_TIMEOUT "300s"
```
in the deployment yaml files, we don't need to expose these, your current change is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services