You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2008/07/31 21:25:41 UTC
svn commit: r681446 -
/myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
Author: lu4242
Date: Thu Jul 31 12:25:41 2008
New Revision: 681446
URL: http://svn.apache.org/viewvc?rev=681446&view=rev
Log:
MYFACES-1900 <f:param> violates the JSF spec
Modified:
myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
Modified: myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
URL: http://svn.apache.org/viewvc/myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java?rev=681446&r1=681445&r2=681446&view=diff
==============================================================================
--- myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java (original)
+++ myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java Thu Jul 31 12:25:41 2008
@@ -994,7 +994,11 @@
context.append("{");
context.append("var form = document.forms[formname];");
context.prettyLine();
- context.append("if(typeof form.elements[name]=='undefined')");
+ context.append("if(!typeof form.elements[name]=='undefined' && form.elements[name].nodeName=='INPUT')");
+ context.append("{");
+ context.append("form.elements[name].value=value;");
+ context.append("}");
+ context.append("else");
context.append("{");
context.append("var newInput = document.createElement('input');");
context.prettyLine();
@@ -1008,10 +1012,6 @@
context.prettyLine();
context.append("form.appendChild(newInput);");
context.append("}");
- context.append("else");
- context.append("{");
- context.append("form.elements[name].value=value;");
- context.append("}");
context.append("}");