You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Paul Inglis (JIRA)" <ji...@apache.org> on 2010/01/27 10:55:34 UTC

[jira] Created: (WSCOMMONS-524) ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3

ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3
---------------------------------------------------------------------------------------------------------

                 Key: WSCOMMONS-524
                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-524
             Project: WS-Commons
          Issue Type: Bug
          Components: Transport
    Affects Versions: Transports 1.0, Transports 1.1
         Environment: SwiftMQ 2.1.3, 
            Reporter: Paul Inglis
            Priority: Minor
             Fix For: Transports 1.1


Hi,

I have an issue reading JMS messages from an old JMS 1.0 implementation provided by swiftMQ as part of a transaction.  The transaction always rolls back and never commits a read from the queue.

Looking at ServiceTaskManager, in the method handleMessage, the logic it takes is:

  1. pass message to jmsMessageReceiver for processing
  2. close the consumer
  3. commit or rollback transaction on session.
  4. close session
  5. close connection

It appears though that at stage 2 with swiftMQ the open transaction is rolledback.  This means the commit in stage 3 does nothing.

The solution is swap stages 2 and 3 such that the open transaction is commited before the consumer is closed. 

I noticted this issue on the verison of Transports (1.0) that ships with WSO2's ESB product but it appears that the same issue applies to 1.1 as well.

Paul Inglis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-524) ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3

Posted by "Rajika Kumarasiri (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840016#action_12840016 ] 

Rajika Kumarasiri commented on WSCOMMONS-524:
---------------------------------------------

Actually the patch was submitted by Paul Inglis.

Rajika

> ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-524
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-524
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: Transports 1.0, Transports 1.1
>         Environment: SwiftMQ 2.1.3, 
>            Reporter: Paul Inglis
>            Assignee: Ruwan Linton
>            Priority: Minor
>             Fix For: Transports 1.1
>
>         Attachments: ServiceTaskManager.patch.txt
>
>
> Hi,
> I have an issue reading JMS messages from an old JMS 1.0 implementation provided by swiftMQ as part of a transaction.  The transaction always rolls back and never commits a read from the queue.
> Looking at ServiceTaskManager, in the method handleMessage, the logic it takes is:
>   1. pass message to jmsMessageReceiver for processing
>   2. close the consumer
>   3. commit or rollback transaction on session.
>   4. close session
>   5. close connection
> It appears though that at stage 2 with swiftMQ the open transaction is rolledback.  This means the commit in stage 3 does nothing.
> The solution is swap stages 2 and 3 such that the open transaction is commited before the consumer is closed. 
> I noticted this issue on the verison of Transports (1.0) that ships with WSO2's ESB product but it appears that the same issue applies to 1.1 as well.
> Paul Inglis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WSCOMMONS-524) ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3

Posted by "Paul Inglis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Inglis updated WSCOMMONS-524:
----------------------------------

    Attachment: ServiceTaskManager.patch.txt

This patch fixes the issue for me swiftMQ.  I've not tested it with other JMS implementations though.





> ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-524
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-524
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: Transports 1.0, Transports 1.1
>         Environment: SwiftMQ 2.1.3, 
>            Reporter: Paul Inglis
>            Priority: Minor
>             Fix For: Transports 1.1
>
>         Attachments: ServiceTaskManager.patch.txt
>
>
> Hi,
> I have an issue reading JMS messages from an old JMS 1.0 implementation provided by swiftMQ as part of a transaction.  The transaction always rolls back and never commits a read from the queue.
> Looking at ServiceTaskManager, in the method handleMessage, the logic it takes is:
>   1. pass message to jmsMessageReceiver for processing
>   2. close the consumer
>   3. commit or rollback transaction on session.
>   4. close session
>   5. close connection
> It appears though that at stage 2 with swiftMQ the open transaction is rolledback.  This means the commit in stage 3 does nothing.
> The solution is swap stages 2 and 3 such that the open transaction is commited before the consumer is closed. 
> I noticted this issue on the verison of Transports (1.0) that ships with WSO2's ESB product but it appears that the same issue applies to 1.1 as well.
> Paul Inglis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-524) ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3

Posted by "Rajika Kumarasiri (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828007#action_12828007 ] 

Rajika Kumarasiri commented on WSCOMMONS-524:
---------------------------------------------

hi,
I tested the patch with ActiveMQ JMS provider and I didn't come across any issue. I think it's safe to apply the patch. 

Rajika

> ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-524
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-524
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: Transports 1.0, Transports 1.1
>         Environment: SwiftMQ 2.1.3, 
>            Reporter: Paul Inglis
>            Priority: Minor
>             Fix For: Transports 1.1
>
>         Attachments: ServiceTaskManager.patch.txt
>
>
> Hi,
> I have an issue reading JMS messages from an old JMS 1.0 implementation provided by swiftMQ as part of a transaction.  The transaction always rolls back and never commits a read from the queue.
> Looking at ServiceTaskManager, in the method handleMessage, the logic it takes is:
>   1. pass message to jmsMessageReceiver for processing
>   2. close the consumer
>   3. commit or rollback transaction on session.
>   4. close session
>   5. close connection
> It appears though that at stage 2 with swiftMQ the open transaction is rolledback.  This means the commit in stage 3 does nothing.
> The solution is swap stages 2 and 3 such that the open transaction is commited before the consumer is closed. 
> I noticted this issue on the verison of Transports (1.0) that ships with WSO2's ESB product but it appears that the same issue applies to 1.1 as well.
> Paul Inglis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-524) ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3

Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806287#action_12806287 ] 

Ruwan Linton commented on WSCOMMONS-524:
----------------------------------------

Hi Paul,

Thanks for the contribution, we will test the patch on some other JMS provider and get this into the 1.1 release.

Thanks,
Ruwan

> ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-524
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-524
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: Transports 1.0, Transports 1.1
>         Environment: SwiftMQ 2.1.3, 
>            Reporter: Paul Inglis
>            Priority: Minor
>             Fix For: Transports 1.1
>
>         Attachments: ServiceTaskManager.patch.txt
>
>
> Hi,
> I have an issue reading JMS messages from an old JMS 1.0 implementation provided by swiftMQ as part of a transaction.  The transaction always rolls back and never commits a read from the queue.
> Looking at ServiceTaskManager, in the method handleMessage, the logic it takes is:
>   1. pass message to jmsMessageReceiver for processing
>   2. close the consumer
>   3. commit or rollback transaction on session.
>   4. close session
>   5. close connection
> It appears though that at stage 2 with swiftMQ the open transaction is rolledback.  This means the commit in stage 3 does nothing.
> The solution is swap stages 2 and 3 such that the open transaction is commited before the consumer is closed. 
> I noticted this issue on the verison of Transports (1.0) that ships with WSO2's ESB product but it appears that the same issue applies to 1.1 as well.
> Paul Inglis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WSCOMMONS-524) ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3

Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruwan Linton resolved WSCOMMONS-524.
------------------------------------

    Resolution: Fixed

Fixed on the trunk, thanks Rajika for the contribution

> ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-524
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-524
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: Transports 1.0, Transports 1.1
>         Environment: SwiftMQ 2.1.3, 
>            Reporter: Paul Inglis
>            Assignee: Ruwan Linton
>            Priority: Minor
>             Fix For: Transports 1.1
>
>         Attachments: ServiceTaskManager.patch.txt
>
>
> Hi,
> I have an issue reading JMS messages from an old JMS 1.0 implementation provided by swiftMQ as part of a transaction.  The transaction always rolls back and never commits a read from the queue.
> Looking at ServiceTaskManager, in the method handleMessage, the logic it takes is:
>   1. pass message to jmsMessageReceiver for processing
>   2. close the consumer
>   3. commit or rollback transaction on session.
>   4. close session
>   5. close connection
> It appears though that at stage 2 with swiftMQ the open transaction is rolledback.  This means the commit in stage 3 does nothing.
> The solution is swap stages 2 and 3 such that the open transaction is commited before the consumer is closed. 
> I noticted this issue on the verison of Transports (1.0) that ships with WSO2's ESB product but it appears that the same issue applies to 1.1 as well.
> Paul Inglis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WSCOMMONS-524) ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3

Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruwan Linton reassigned WSCOMMONS-524:
--------------------------------------

    Assignee: Ruwan Linton

> ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-524
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-524
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: Transports 1.0, Transports 1.1
>         Environment: SwiftMQ 2.1.3, 
>            Reporter: Paul Inglis
>            Assignee: Ruwan Linton
>            Priority: Minor
>             Fix For: Transports 1.1
>
>         Attachments: ServiceTaskManager.patch.txt
>
>
> Hi,
> I have an issue reading JMS messages from an old JMS 1.0 implementation provided by swiftMQ as part of a transaction.  The transaction always rolls back and never commits a read from the queue.
> Looking at ServiceTaskManager, in the method handleMessage, the logic it takes is:
>   1. pass message to jmsMessageReceiver for processing
>   2. close the consumer
>   3. commit or rollback transaction on session.
>   4. close session
>   5. close connection
> It appears though that at stage 2 with swiftMQ the open transaction is rolledback.  This means the commit in stage 3 does nothing.
> The solution is swap stages 2 and 3 such that the open transaction is commited before the consumer is closed. 
> I noticted this issue on the verison of Transports (1.0) that ships with WSO2's ESB product but it appears that the same issue applies to 1.1 as well.
> Paul Inglis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WSCOMMONS-524) ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3

Posted by "Paul Inglis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805444#action_12805444 ] 

Paul Inglis edited comment on WSCOMMONS-524 at 1/27/10 9:56 AM:
----------------------------------------------------------------

This patch fixes the issue for me with swiftMQ.  I've not tested it with other JMS implementations though.


      was (Author: pinglis):
    This patch fixes the issue for me swiftMQ.  I've not tested it with other JMS implementations though.




  
> ServiceTaskManager fails to commit if session is transacted and always rollsback when using swiftMQ 2.1.3
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-524
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-524
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: Transports 1.0, Transports 1.1
>         Environment: SwiftMQ 2.1.3, 
>            Reporter: Paul Inglis
>            Priority: Minor
>             Fix For: Transports 1.1
>
>         Attachments: ServiceTaskManager.patch.txt
>
>
> Hi,
> I have an issue reading JMS messages from an old JMS 1.0 implementation provided by swiftMQ as part of a transaction.  The transaction always rolls back and never commits a read from the queue.
> Looking at ServiceTaskManager, in the method handleMessage, the logic it takes is:
>   1. pass message to jmsMessageReceiver for processing
>   2. close the consumer
>   3. commit or rollback transaction on session.
>   4. close session
>   5. close connection
> It appears though that at stage 2 with swiftMQ the open transaction is rolledback.  This means the commit in stage 3 does nothing.
> The solution is swap stages 2 and 3 such that the open transaction is commited before the consumer is closed. 
> I noticted this issue on the verison of Transports (1.0) that ships with WSO2's ESB product but it appears that the same issue applies to 1.1 as well.
> Paul Inglis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.