You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by gi...@git.apache.org on 2017/09/29 01:47:17 UTC
[GitHub] ccollins476ad opened a new pull request #587: testutil - Clear message after failure reported
ccollins476ad opened a new pull request #587: testutil - Clear message after failure reported
URL: https://github.com/apache/mynewt-core/pull/587
If a test case was reported with a message (e.g., an assertion failure),
the message gets duplicated for all subsequent test cases. For
example:
```
[pass] ble_os_test_suite/ble_os_disc_test_case
[pass] ble_os_test_suite/ble_gap_direct_connect_test_case
[pass] ble_os_test_suite/ble_gap_terminate_test_case
[FAIL] ble_hs_pvcy_test_suite_irk/ble_hs_pvcy_test_case_restore_irks |net/nimble/host/test/src/ble_hs_pvcy_test.c:34| failed assertion: rc == 0
[pass] ble_sm_gen_test_suite/ble_sm_test_case_f4
|net/nimble/host/test/src/ble_hs_pvcy_test.c:34| failed assertion: rc == 0
[pass] ble_sm_gen_test_suite/ble_sm_test_case_f5
|net/nimble/host/test/src/ble_hs_pvcy_test.c:34| failed assertion: rc == 0
[pass] ble_sm_gen_test_suite/ble_sm_test_case_f6
|net/nimble/host/test/src/ble_hs_pvcy_test.c:34| failed assertion: rc == 0
[pass] ble_sm_gen_test_suite/ble_sm_test_case_g2
|net/nimble/host/test/src/ble_hs_pvcy_test.c:34| failed assertion: rc == 0
[pass] ble_sm_gen_test_suite/ble_sm_test_case_peer_fail_inval
```
The first three cases passed with no message. Then, the fourth failed
with a message ("failed assertion: rc == 0"). The subsequent test cases
incorrectly report the failure message from before.
This commit clears the message buffer after a case gets reported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services