[GitHub] [calcite] danny0405 commented on a change in pull request #1275: [CALCITE-3136]Fix the default rule description of ConverterRule

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #1275: [CALCITE-3136]Fix the default rule description of ConverterRule
URL: https://github.com/apache/calcite/pull/1275#discussion_r298874363
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/RelOptRule.java
 ##########
 @@ -536,8 +536,8 @@ public RelTrait getOutTrait() {
    * Returns the description of this rule.
    *
    * <p>It must be unique (for rules that are not equal) and must consist of
-   * only the characters A-Z, a-z, 0-9, '_', '.', '(', ')'. It must start with
-   * a letter. */
+   * only the characters A-Z, a-z, 0-9, '_', '.', '(', ')', '-', ',', '[', ']'.
+   * It must start with a letter. */
   public final String toString() {
 
 Review comment:
   Why add `-` here ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services