You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "Andrus Adamchik (JIRA)" <ji...@apache.org> on 2010/10/11 13:20:33 UTC

[jira] Created: (CAY-1490) Maven cgen: all and datamap modes can not be activated

Maven cgen: all and datamap modes can not be activated
------------------------------------------------------

                 Key: CAY-1490
                 URL: https://issues.apache.org/jira/browse/CAY-1490
             Project: Cayenne
          Issue Type: Bug
    Affects Versions: 3.0.1, 3.1M1
            Reporter: Andrus Adamchik
            Assignee: Andrus Adamchik


This was reported on the user list, and my own tests seem to confirm that setting <mode>datamap</mode> or <mode>all</mode> don't result in class generation for a DataMap. Setting <mode>entity</mode> or omitting "mode" tag, results in correct generation of classes for all entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (CAY-1490) Maven cgen: all and datamap modes can not be activated

Posted by "Andrus Adamchik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrus Adamchik updated CAY-1490:
---------------------------------

    Fix Version/s: 3.1M1
                   3.0.2

> Maven cgen: all and datamap modes can not be activated
> ------------------------------------------------------
>
>                 Key: CAY-1490
>                 URL: https://issues.apache.org/jira/browse/CAY-1490
>             Project: Cayenne
>          Issue Type: Bug
>    Affects Versions: 3.0.1, 3.1M1
>            Reporter: Andrus Adamchik
>            Assignee: Andrus Adamchik
>             Fix For: 3.0.2, 3.1M1
>
>         Attachments: CAY-1490-3.0.patch, CAY-1490.patch
>
>
> This was reported on the user list, and my own tests seem to confirm that setting <mode>datamap</mode> or <mode>all</mode> don't result in class generation for a DataMap. Setting <mode>entity</mode> or omitting "mode" tag, results in correct generation of classes for all entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (CAY-1490) Maven cgen: all and datamap modes can not be activated

Posted by "Andrus Adamchik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrus Adamchik closed CAY-1490.
--------------------------------

    Resolution: Fixed

Thanks Andrei. I committed the patches (will commit 3.0 patch shortly, it seems SVN is acting up at the moment). The generator logic seems even more convoluted than your assessment. Without trying, I think calling generator.addQueries(queries) would result in a DataMap-related class generator run. There is a check for "queries != null", but there's no check for "queries.is Empty()".

> Maven cgen: all and datamap modes can not be activated
> ------------------------------------------------------
>
>                 Key: CAY-1490
>                 URL: https://issues.apache.org/jira/browse/CAY-1490
>             Project: Cayenne
>          Issue Type: Bug
>    Affects Versions: 3.0.1, 3.1M1
>            Reporter: Andrus Adamchik
>            Assignee: Andrus Adamchik
>         Attachments: CAY-1490-3.0.patch, CAY-1490.patch
>
>
> This was reported on the user list, and my own tests seem to confirm that setting <mode>datamap</mode> or <mode>all</mode> don't result in class generation for a DataMap. Setting <mode>entity</mode> or omitting "mode" tag, results in correct generation of classes for all entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (CAY-1490) Maven cgen: all and datamap modes can not be activated

Posted by "Andrei Veprev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAY-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Veprev updated CAY-1490:
-------------------------------

    Attachment: CAY-1490-3.0.patch
                CAY-1490.patch

Here are patches for trunk and 3.0 versions.

One note. Data map class is generated only if some queries (named queries) exist in data map file. I didn't change this behavior.

> Maven cgen: all and datamap modes can not be activated
> ------------------------------------------------------
>
>                 Key: CAY-1490
>                 URL: https://issues.apache.org/jira/browse/CAY-1490
>             Project: Cayenne
>          Issue Type: Bug
>    Affects Versions: 3.0.1, 3.1M1
>            Reporter: Andrus Adamchik
>            Assignee: Andrus Adamchik
>         Attachments: CAY-1490-3.0.patch, CAY-1490.patch
>
>
> This was reported on the user list, and my own tests seem to confirm that setting <mode>datamap</mode> or <mode>all</mode> don't result in class generation for a DataMap. Setting <mode>entity</mode> or omitting "mode" tag, results in correct generation of classes for all entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.