You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/04 15:30:06 UTC

[GitHub] [airflow] ashb commented on a change in pull request #13278: fix dag run type enum query for mysqldb driver

ashb commented on a change in pull request #13278:
URL: https://github.com/apache/airflow/pull/13278#discussion_r551386256



##########
File path: airflow/models/dagrun.py
##########
@@ -298,7 +298,7 @@ def find(
     @staticmethod
     def generate_run_id(run_type: DagRunType, execution_date: datetime) -> str:
         """Generate Run ID based on Run Type and Execution Date"""
-        return f"{run_type}__{execution_date.isoformat()}"
+        return f"{run_type.value}__{execution_date.isoformat()}"

Review comment:
       We don't need this now you've got a `__str__` method on the enum do we?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org