You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/01 00:30:45 UTC

[GitHub] [beam] aaltay commented on a change in pull request #12444: Added a whitespace lint as part of python lint precommit

aaltay commented on a change in pull request #12444:
URL: https://github.com/apache/beam/pull/12444#discussion_r463896381



##########
File path: sdks/python/scripts/run_pylint.sh
##########
@@ -37,6 +37,11 @@ fi
 set -o errexit
 set -o pipefail
 
+# Check for trailing spaces in non-Python text files.
+echo "Running whitespacelint..."
+MARKDOWN=$(find apache_beam -name '*.md' -print0)

Review comment:
       a bit strange to apply this only when there is a python change. md files could be anywhere in the repo.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org