[GitHub] [tvm] Leo-arm commented on a change in pull request #10130: [ETHOSN] Add support for mean on Ethos-N78

[GitBox <gi...@apache.org>]

Leo-arm commented on a change in pull request #10130:
URL: https://github.com/apache/tvm/pull/10130#discussion_r798397473



##########
File path: python/tvm/relay/op/contrib/ethosn.py
##########
@@ -178,18 +186,29 @@ def check_avg_pool2d(extract):
 
         return support.avg_pool2d(extract)
 
+    def check_mean(extract):
+        """Check if mean is supported by Ethos-N."""
+        if not ethosn_available():
+            return False
+
+        return support.mean(extract)
+
     def check_sigmoid(extract):
         """Check if a sigmoid is supported by Ethos-N."""
         if not ethosn_available():
             return False
 
+        if extract.attrs.out_dtype != "uint8":
+            return False
+

Review comment:
       This should not be here because the int8 support for sigmoid has been merged earlier this week.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org