You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/04 17:51:44 UTC

[GitHub] [flink] qqibrow opened a new pull request #11987: [hotfix] Show hostname in failure error message

qqibrow opened a new pull request #11987:
URL: https://github.com/apache/flink/pull/11987


   Adding hostname in error message could help us detect host issue. The new error message would be like:
   ```
   2019-12-07 05:04:43,264 INFO  org.apache.flink.runtime.executiongraph.ExecutionGraph        - KeyedProcess -> Sink: Unnamed (1/1) (52bd0b7c29cdcf040448660e7c52a03d) switched from RUNNING to FAILED on container_e07_1575407974804_0477_01_000002 @ monarch-dev-021-20181106-data-slave-dev-0a02472a.ec2.pin220.com (dataPort=35719).
   org.apache.flink.util.FlinkException: The assigned slot container_e07_1575407974804_0477_01_000002_0 was removed.
   	at org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager.removeSlot(SlotManager.java:893)
   	at org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager.removeSlots(SlotManager.java:863)
   	at org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager.internalUnregisterTaskManager(SlotManager.java:1058)
   	at org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager.unregisterTaskManager(SlotManager.java:385)
   	at org.apache.flink.runtime.resourcemanager.ResourceManager.closeTaskManagerConnection(ResourceManager.java:830)
   	at org.apache.flink.yarn.YarnResourceManager.lambda$onContainersCompleted$0(YarnResourceManager.java:363)
   	at org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleRunAsync(AkkaRpcActor.java:332)
   	at org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleRpcMessage(AkkaRpcActor.java:158)
   	at org.apache.flink.runtime.rpc.akka.FencedAkkaRpcActor.handleRpcMessage(FencedAkkaRpcActor.java:70)
   	at org.apache.flink.runtime.rpc.akka.AkkaRpcActor.onReceive(AkkaRpcActor.java:142)
   	at org.apache.flink.runtime.rpc.akka.FencedAkkaRpcActor.onReceive(FencedAkkaRpcActor.java:40)
   	at akka.actor.UntypedActor$$anonfun$receive$1.applyOrElse(UntypedActor.scala:165)
   	at akka.actor.Actor$class.aroundReceive(Actor.scala:502)
   	at akka.actor.UntypedActor.aroundReceive(UntypedActor.scala:95)
   	at akka.actor.ActorCell.receiveMessage(ActorCell.scala:526)
   	at akka.actor.ActorCell.invoke(ActorCell.scala:495)
   	at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257)
   	at akka.dispatch.Mailbox.run(Mailbox.scala:224)
   	at akka.dispatch.Mailbox.exec(Mailbox.scala:234)
   	at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
   	at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
   	at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
   	at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #11987: [hotfix] Show hostname in failure error message

Posted by GitBox <gi...@apache.org>.

tillrohrmann closed pull request #11987:
URL: https://github.com/apache/flink/pull/11987


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #11987: [hotfix] Show hostname in failure error message

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #11987:
URL: https://github.com/apache/flink/pull/11987#issuecomment-623621331


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "db7481419288348aebf6a09127410424ff517b01",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "db7481419288348aebf6a09127410424ff517b01",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * db7481419288348aebf6a09127410424ff517b01 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #11987: [hotfix] Show hostname in failure error message

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #11987:
URL: https://github.com/apache/flink/pull/11987#issuecomment-623611390

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit db7481419288348aebf6a09127410424ff517b01 (Mon May 04 17:53:44 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #11987: [hotfix] Show hostname in failure error message

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #11987:
URL: https://github.com/apache/flink/pull/11987#issuecomment-623611390

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit db7481419288348aebf6a09127410424ff517b01 (Fri Oct 16 10:36:30 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on a change in pull request #11987: [hotfix] Show hostname in failure error message

Posted by GitBox <gi...@apache.org>.

tillrohrmann commented on a change in pull request #11987:
URL: https://github.com/apache/flink/pull/11987#discussion_r426428629



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1568,7 +1568,7 @@ private boolean transitionState(ExecutionState currentState, ExecutionState targ
 			if (error == null) {
 				LOG.info("{} ({}) switched from {} to {}.", getVertex().getTaskNameWithSubtaskIndex(), getAttemptId(), currentState, targetState);
 			} else {
-				LOG.info("{} ({}) switched from {} to {}.", getVertex().getTaskNameWithSubtaskIndex(), getAttemptId(), currentState, targetState, error);
+				LOG.info("{} ({}) switched from {} to {} on {}.", getVertex().getTaskNameWithSubtaskIndex(), getAttemptId(), currentState, targetState, getVertex().getCurrentAssignedResourceLocation(), error);

Review comment:
       ```suggestion
   				LOG.info("{} ({}) switched from {} to {} on {}.", getVertex().getTaskNameWithSubtaskIndex(), getAttemptId(), currentState, targetState, getAssignedResource(), error);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org