You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by dg...@apache.org on 2003/09/26 08:22:05 UTC
cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html CheckboxTag.java
dgraham 2003/09/25 23:22:05
Modified: src/share/org/apache/struts/taglib/html CheckboxTag.java
Log:
Removed the instanceof String check before calling
result.toString(). If result is already a String, there is no
harm in calling its toString() method.
Revision Changes Path
1.20 +6 -8 jakarta-struts/src/share/org/apache/struts/taglib/html/CheckboxTag.java
Index: CheckboxTag.java
===================================================================
RCS file: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/CheckboxTag.java,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- CheckboxTag.java 31 Jul 2003 00:19:04 -0000 1.19
+++ CheckboxTag.java 26 Sep 2003 06:22:05 -0000 1.20
@@ -202,10 +202,8 @@
result = "";
}
- if (!(result instanceof String)) {
- result = result.toString();
- }
-
+ result = result.toString();
+
String checked = (String) result;
if (checked.equalsIgnoreCase(value)
|| checked.equalsIgnoreCase("true")
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org