[GitHub] [pulsar] klwilson227 commented on pull request #10246: Add support for deduplication testing

[GitBox <gi...@apache.org>]

klwilson227 commented on pull request #10246:
URL: https://github.com/apache/pulsar/pull/10246#issuecomment-821209966


   Merlimat, RE the consumer side, I'm sure the consumer side would also benefit as well for a possible demo/software acceptance level validation. However, in my particular use case the validation and scanning for duplicates and lost records was easier implemented in the Data Sink which received the data  hence I did not invest extra to build a data validation layer within pulsar test client, only the ability to publish data using both the dedup enabled and dedup disabled.
   
   Since, I did not have the requirement, it was not coded. And I did not want to assume that this was a requirement, as a poor implementation may show both strengths and weaknesses in the platform.  I can certainly take it in that direction. But would think that may be a separate PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org