You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/01/02 17:39:10 UTC

[Bug 123950] New: Visible area of cropped raster graphic (bitmap) changes when rotating

https://issues.apache.org/ooo/show_bug.cgi?id=123950

            Bug ID: 123950
        Issue Type: DEFECT
           Summary: Visible area of cropped raster graphic (bitmap)
                    changes when rotating
           Product: Draw
           Version: 3.4.0
          Hardware: PC
                OS: Windows 7
            Status: UNCONFIRMED
          Keywords: regression
          Severity: major
          Priority: P3
         Component: editing
          Assignee: issues@openoffice.apache.org
          Reporter: rainerbielefeld_ooo_qa@bielefeldundbuss.de
                CC: issues@openoffice.apache.org

Created attachment 82201
  --> https://issues.apache.org/ooo/attachment.cgi?id=82201&action=edit
Sample Document with Screenshot

Steps how to reproduce with "AOO 4.0.1   – German UI / German locale  [Rev.
1524958 2013-09-20 11:40:29]" on  German WIN7 Home Premium (64bit)", “historic”
 4.0  User Profile used for all  predecessor versions:

1. Open attached Sample document from AOO Start Center
2. In first slide select "Original Picture Cropped"
   > Control points appear
3. Menu 'Modify -> Rotate'
   > Rotate handles appear
4. Move mouse pointer to top right corner rotation control handle
   > Mouse pointer view chantes to "rotation"
5. To a 360° rotation counter clockwise and watch what happens
   Expected: Visible area of original shape stays the same all time, none 
             of the colored margins will appear
   Actual: Borders appear, visible area changes.                           :-(

Additional Info:
----------------
(a) Already reproducible with server installation of  "AOO 3.4.0 – German UI / 
    German locale [AOO340m1(Build:9590) - Rev.1327774]" on German WIN7 Home 
    Premium (64bit)", own separate user profile
(b) Was still ok with  sever installation of "OOo 3.3.0 English UI / 
    German locale [OOO330m20 (Build 9567)]" on  WIN7  Home Premium  (64bit) DE 
(c) also a Problem with LibO 4.1.3
(d) but was still ok with LibO 3.3.3
(e) If you want to do quick tests you only need to watch the 2 rotated 
    pictures "Picture Cropped 45°" and "Picture Cropped 90°", if green or
    blue margin is visible the version is affected.
(e) General problem what I see with many of my Drawing Documents.
(f) It does not matter whether I crop using crop handles or crop dialog

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |ACCEPTED

--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
Redefined the CropPrimitive2D::get2DDecomposition implementation to make it
shear and rotation independent. Could even simplify it by unifications and
doing the needed manipulations in unit coordiante system, so that no care has
to be taken if the cropped content is mirrored, sheared or scaled at all.
Committing that part which corrects the visualization.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

fanyuzhen@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fanyuzhen@gmail.com
         QA Contact|                            |clarence.guo.bj@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

--- Comment #8 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1560574 into trunk:
i123950 unified and redefined CropPrimitive2D::get2DDecomposition

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

--- Comment #13 from Armin Le Grand <Ar...@me.com> ---
Made shear work (core has shear wrong defined, need to correct when using with
homogen matrices), made handles rotated and sheared if needed, mirroring
(following old definitions, all already change din aw080) in the works...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

zhaoshzh <ao...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aoo.zhaoshzh@gmail.com

--- Comment #18 from zhaoshzh <ao...@gmail.com> ---
verified on AOO410m1(build:9750) - rev:1566593

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

Regina Henschel <rb...@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rb.henschel@t-online.de

--- Comment #3 from Regina Henschel <rb...@t-online.de> ---
That are likely the same problems as in bug 94090.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Armin Le Grand <Ar...@me.com> ---
Comitted, done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

--- Comment #12 from Armin Le Grand <Ar...@me.com> ---
Pretty far, about to add roated handles (the bitmaps). Had to make more changes
as expected, but thats how it always is...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

Rainer Bielefeld <ra...@bielefeldundbuss.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rainerbielefeld_ooo_qa@biel
                   |                            |efeldundbuss.de
             Latest|---                         |4.1-dev
    Confirmation on|                            |

--- Comment #1 from Rainer Bielefeld <ra...@bielefeldundbuss.de> ---
(g) Still Reproducible with server installation of "AOO 4.1.0-Dev – English  UI
/ English locale - [AOO410m1(Build:9750)  -  Rev. 1554205 - 2014-01-01]" on
German WIN7 Home Premium (64bit)", own separate user profile.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
                   |g                           |
   Target Milestone|---                         |4.1.0

--- Comment #17 from Armin Le Grand <Ar...@me.com> ---
Changed state and owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

--- Comment #10 from Armin Le Grand <Ar...@me.com> ---
Just checked to make sure in a AOO401 (AOO401m5(Build:9714)  -  Rev. 1524958
2013-09-20 11:40:29 (Fr, 20 Sep 2013)) to check if the visualization worked -
it did not, as I had in my mind. Still, this should work once, so I will check
for how much the UI stuff is. It seems as if the 'point mode' would be
preferable for adding the crop handles there, currently the object mode is
used. Point mode is better or single-selection (what crop is anyways). The
basic interactions (move handles just in directions aligned to the
sheared/rotated object) are already there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

--- Comment #11 from Armin Le Grand <Ar...@me.com> ---
Checked in AOO3.4, same error
Checked with OOo3.3, same error (even crashed once and no shear for graphic
objects)
Checked with OOo3.2, same error (no shear)
Checked with OOo2.2, same error, crop gets lost on paste, no crop UI, no shear

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

fanyuzhen@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED
         QA Contact|clarence.guo.bj@gmail.com   |aoo.zhaoshzh@gmail.com

--- Comment #19 from fanyuzhen@gmail.com ---
Change status per Shao Zhi Zhao's verification

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

--- Comment #15 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1561756 into trunk:
i123950 Corrected/extended interactive crop feature to work in all situations

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

--- Comment #4 from Rainer Bielefeld <ra...@bielefeldundbuss.de> ---
(In reply to Regina Henschel from comment #3)
I checked that report, simply was not sure whether I understood all details of
Bug 94090 ... 

And version of appearance does not match, this one appeared with AOO 3.4, but
Bug 94090 already appeared in the 300 code line

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Armin.Le.Grand@me.com

--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
This is a known error and is like that since cropping was implemented. The ones
doing it just ignored or did not know that graphic objects can be rotated. I
have this in my focus to fix it, but it is no regression.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

--- Comment #14 from Armin Le Grand <Ar...@me.com> ---
Needed a lot of fine tuning with the old core model definitions, would have
been much easier with aw080 where the mirrorings are real mirrorings defined in
the objects transformation. Works now, but will need the same fine tuning again
in aw080.
GraphicObjects can now be cropped in any state, if mirrored, sheared or
rotated. The preview of the cropped part will work in any state, too. This
makes the feature of interactive cropping fully working and implemented for the
first time. Preparing commit...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

Edwin Sharp <el...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |elish@apache.org
     Ever confirmed|0                           |1

--- Comment #2 from Edwin Sharp <el...@apache.org> ---
Confirmed with
AOO410m1(Build:9750)  -  Rev. 1552994
Rev.1552994
Win 7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
I implemented the visible preview of cropped parts for AOO400, that part works
already. I can check how much work it would be...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123950] Visible area of cropped raster graphic (bitmap) changes when rotating

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123950

--- Comment #9 from Armin Le Grand <Ar...@me.com> ---
Okay, done. Lets see what can be done with the UI interaction handling
tomorrow...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.