You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2016/02/08 13:15:05 UTC
[GitHub] couchdb-nmo pull request: Small fixes
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-nmo/pull/24
Small fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-nmo small-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-nmo/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit 977d0f900c128fce8559b78233c1b9ccd359237d
Author: Garren Smith <ga...@gmail.com>
Date: 2016-02-08T12:12:24Z
add extension points for variables
commit edd4ebbd5f67d2f3a4b560108c3efe953beb92ef
Author: Garren Smith <ga...@gmail.com>
Date: 2016-02-08T12:12:51Z
Add .md file extension to activetasks
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Small fixes
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-nmo/pull/24#discussion_r52164571
--- Diff: src/nmo.js ---
@@ -49,6 +49,8 @@ nmo.load = function load (opts) {
.load(opts)
.then((config) => {
nmo.config = config;
+ nmo.config.set('name', 'nmo');
+ nmo.config.set('help-directory', `${__dirname}/..`);
--- End diff --
not sure if we need to migrate old other config. the `ini` module should make migration a 4-5 liner
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Small fixes
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/24#issuecomment-181356876
i thought about that.
i would suggest to directly use the `name` field from the `package.json` to make nmo reusable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Small fixes
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-nmo/pull/24#discussion_r52164499
--- Diff: src/nmo.js ---
@@ -49,6 +49,8 @@ nmo.load = function load (opts) {
.load(opts)
.then((config) => {
nmo.config = config;
+ nmo.config.set('name', 'nmo');
+ nmo.config.set('help-directory', `${__dirname}/..`);
--- End diff --
ehm i mean default config file, not template
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Small fixes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-nmo/pull/24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Small fixes
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-nmo/pull/24#discussion_r52164236
--- Diff: src/nmo.js ---
@@ -49,6 +49,8 @@ nmo.load = function load (opts) {
.load(opts)
.then((config) => {
nmo.config = config;
+ nmo.config.set('name', 'nmo');
+ nmo.config.set('help-directory', `${__dirname}/..`);
--- End diff --
hmmm...
what do you think of adding them as defaults to the nmo conf file that is placed into the home dir?
this smells dangerously for race conditions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Small fixes
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-nmo/pull/24#discussion_r52162366
--- Diff: src/help.js ---
@@ -24,13 +24,16 @@ export default help;
export const cli = helpCli;
function helpCli (cmd) {
return new Promise((resolve, reject) => {
+ const name = nmo.config.get('name');
+ const helpDir = nmo.config.get('help-directory');
if (!cmd || !nmo.commands[cmd]) {
help();
return resolve();
}
- const path = `${__dirname}/../man/man1/nmo-${cmd}.1`;
+ const path = `${helpDir}/man/man1/${name}-${cmd}.1`;
+ console.log('ppp', path, name, process.cwd());
--- End diff --
debug output
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Small fixes
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-nmo/pull/24#discussion_r52164324
--- Diff: src/nmo.js ---
@@ -49,6 +49,8 @@ nmo.load = function load (opts) {
.load(opts)
.then((config) => {
nmo.config = config;
+ nmo.config.set('name', 'nmo');
+ nmo.config.set('help-directory', `${__dirname}/..`);
--- End diff --
Thats a good idea. I will do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Small fixes
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/24#issuecomment-181397815
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Small fixes
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-nmo/pull/24#discussion_r52164460
--- Diff: src/nmo.js ---
@@ -49,6 +49,8 @@ nmo.load = function load (opts) {
.load(opts)
.then((config) => {
nmo.config = config;
+ nmo.config.set('name', 'nmo');
+ nmo.config.set('help-directory', `${__dirname}/..`);
--- End diff --
we might want include a separate template which is then loaded here https://github.com/garrensmith/couchdb-nmo/blob/small-fixes/bin/nmo-cli.js#L24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---