You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/20 04:01:06 UTC

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #17302: [numpy]add op random.logistic, random.gumbel

reminisce commented on a change in pull request #17302: [numpy]add op random.logistic, random.gumbel
URL: https://github.com/apache/incubator-mxnet/pull/17302#discussion_r368362440
 
 

 ##########
 File path: python/mxnet/ndarray/numpy/random.py
 ##########
 @@ -193,6 +194,83 @@ def normal(loc=0.0, scale=1.0, size=None, dtype=None, ctx=None, out=None):
                            ctx=ctx, dtype=dtype, out=out)
 
 
+def logistic(loc=0.0, scale=1.0, size=None):
 
 Review comment:
   Can we support `ctx` as well? Otherwise, GPU implementation is not fully tested.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services