[GitHub] [incubator-streampipes-extensions] tenthe commented on pull request #52: [STREAMPIPES-] Processing Element: Detect Value Change

[GitBox <gi...@apache.org>]

tenthe commented on pull request #52:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/52#issuecomment-948906594


   
   Hi, thanks for updating the pull request.
   Here are a few comments to the current state of the implementation.
   
   - Can you also create a folder for the resources with an icon, documentation and the string values (have a look at the other processors for examples)
   - In the declare model, the configuration for the user input are missing, examples for that can be found in the documentation [1] 
   - To forward the event to the next processor you need to call the spOutputCollector.collect
   
   It might also be a good task to get to know the structure of the processor to select one of the existing once and refactor it to the new API (StreamPipesDataProcessor).
   
   
   [1] https://streampipes.apache.org/docs/docs/extend-sdk-static-properties.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org