You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by tn...@apache.org on 2013/01/20 22:47:52 UTC
svn commit: r1435979 - in
/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections:
ExtendedProperties.java comparators/FixedOrderComparator.java
Author: tn
Date: Sun Jan 20 21:47:51 2013
New Revision: 1435979
URL: http://svn.apache.org/viewvc?rev=1435979&view=rev
Log:
Findbugs fixes: use e.g. Integer.valueOf instead of new Integer and similar.
Modified:
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ExtendedProperties.java
commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/FixedOrderComparator.java
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ExtendedProperties.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ExtendedProperties.java?rev=1435979&r1=1435978&r2=1435979&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ExtendedProperties.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ExtendedProperties.java Sun Jan 20 21:47:51 2013
@@ -1499,7 +1499,7 @@ public class ExtendedProperties extends
* by the key has not a valid number format.
*/
public long getLong(final String key, final long defaultValue) {
- return getLong(key, new Long(defaultValue)).longValue();
+ return getLong(key, Long.valueOf(defaultValue)).longValue();
}
/**
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/FixedOrderComparator.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/FixedOrderComparator.java?rev=1435979&r1=1435978&r2=1435979&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/FixedOrderComparator.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/FixedOrderComparator.java Sun Jan 20 21:47:51 2013
@@ -181,7 +181,7 @@ public class FixedOrderComparator<T> imp
*/
public boolean add(final T obj) {
checkLocked();
- final Integer position = map.put(obj, new Integer(counter++));
+ final Integer position = map.put(obj, Integer.valueOf(counter++));
return position == null;
}