[GitHub] [helix] kaisun2000 opened a new pull request #924: Fix ZkHelixPropertyStore loses Zookeeper notification issue

[GitBox <gi...@apache.org>]

kaisun2000 opened a new pull request #924: Fix ZkHelixPropertyStore loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924
 
 
   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixes #921 
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
       ZkHelixPropertyStore loses ZK notification after session expires.
       The issue was caused by a bug in Share ZkClient code path. More
       specifically, Share ZkClient would not call fireAllEvent when ZK
       session expires. Thus, ZkHelixPropertyStore would not install
       watches for corresponding ZkPath. Thus, lose Zookeeper
       nofiticaition when changes happens.
   
   ### Tests
   
   - [x] The following tests are written for this issue:
   
   testSessionExpirationWithSharedZkClient
   
   - [x] The following is the result of the "mvn test" command on the appropriate module:
   
   ksun-mn1:helix-core ksun$ mvn test
   
   Failed tests: 
     TestZkConnectionLost.testLostZkConnection » ThreadTimeout Method org.testng.in...
     TestJobFailureDependence.testWorkflowFailureJobThreshold » ThreadTimeout Metho...
     TestHelixAdminCli.testInstanceOperations:469 » ZkClient Failed to delete /Test...
   
   Tests run: 1093, Failures: 3, Errors: 0, Skipped: 4
   
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  01:37 h
   [INFO] Finished at: 2020-04-06T18:55:19-07:00
   [INFO] ------------------------------------------------------------------------
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on project helix-core: There are test failures.
   [ERROR] 
   [ERROR] Please refer to /Users/ksun/dev_branch_helix/helix/helix-core/target/surefire-reports for the individual test results.
   [ERROR] -> [Help 1]
   [ERROR] 
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR] 
   [ERROR] For more information about the errors and possible solutions, please read the following articles:
   [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
   
   Individual test case run will all succeed.
   ### Commits
   
   - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org