You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/04 00:49:00 UTC
[jira] [Commented] (BEAM-2724) MSEC counters should support
Structured Names in Dataflow
[ https://issues.apache.org/jira/browse/BEAM-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113748#comment-16113748 ]
ASF GitHub Bot commented on BEAM-2724:
--------------------------------------
GitHub user pabloem opened a pull request:
https://github.com/apache/beam/pull/3684
[BEAM-2724] Preparing support for Structured Names in Dataflow counters
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
---
Adding a CounterName class to help support structured names for counters in the future.
Also remove function calls from the `apiclient.py` file that are no longer used.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pabloem/incubator-beam add-countername
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3684.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3684
----
commit b1e15abc0423ea7c8013f3d745ab97b44c04b5f5
Author: Pablo <pa...@google.com>
Date: 2017-08-04T00:46:09Z
Preparing support for Structured Names in Dataflow counters
----
> MSEC counters should support Structured Names in Dataflow
> ---------------------------------------------------------
>
> Key: BEAM-2724
> URL: https://issues.apache.org/jira/browse/BEAM-2724
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)