You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/02/01 05:48:53 UTC
[GitHub] [spark] itholic opened a new pull request, #39837: [SPARK-42254][SQL] Assign name to _LEGACY_ERROR_TEMP_1117
itholic opened a new pull request, #39837:
URL: https://github.com/apache/spark/pull/39837
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR proposes to assign name to _LEGACY_ERROR_TEMP_1117, "REQUIRES_SINGLE_PART_NAMESPACE".
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We should assign proper name to _LEGACY_ERROR_TEMP_*
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
`./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #39837: [SPARK-42254][SQL] Assign name to _LEGACY_ERROR_TEMP_1117
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #39837:
URL: https://github.com/apache/spark/pull/39837#discussion_r1093328553
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1208,6 +1208,11 @@
],
"sqlState" : "42K03"
},
+ "REQUIRES_SINGLE_PART_NAMESPACE" : {
+ "message" : [
+ "<sessionCatalog> requires a single-part namespace, but got <namespace>."
+ ]
Review Comment:
```suggestion
],
"sqlState" : "42K05"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39837: [SPARK-42254][SQL] Assign name to _LEGACY_ERROR_TEMP_1117
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39837:
URL: https://github.com/apache/spark/pull/39837#discussion_r1095307396
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1208,6 +1208,11 @@
],
"sqlState" : "42K03"
},
+ "REQUIRES_SINGLE_PART_NAMESPACE" : {
+ "message" : [
+ "<sessionCatalog> requires a single-part namespace, but got <namespace>."
+ ]
Review Comment:
Updated, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #39837: [SPARK-42254][SQL] Assign name to _LEGACY_ERROR_TEMP_1117
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #39837:
URL: https://github.com/apache/spark/pull/39837#issuecomment-1411502157
cc @srielau @MaxGekk @cloud-fan could you review this error class when you find some time??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #39837: [SPARK-42254][SQL] Assign name to _LEGACY_ERROR_TEMP_1117
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #39837:
URL: https://github.com/apache/spark/pull/39837#issuecomment-1421796107
+1, LGTM. Merging to master/3.4.
Thank you, @itholic and @LuciferYang @srielau for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39837: [SPARK-42254][SQL] Assign name to _LEGACY_ERROR_TEMP_1117
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39837:
URL: https://github.com/apache/spark/pull/39837#discussion_r1096647928
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -1239,12 +1239,12 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase {
new TableAlreadyExistsException(ident.asMultipartIdentifier)
}
- def requiresSinglePartNamespaceError(ns: Seq[String]): Throwable = {
+ def requiresSinglePartNamespaceError(namespace: Seq[String]): Throwable = {
new AnalysisException(
- errorClass = "_LEGACY_ERROR_TEMP_1117",
+ errorClass = "REQUIRES_SINGLE_PART_NAMESPACE",
messageParameters = Map(
"sessionCatalog" -> CatalogManager.SESSION_CATALOG_NAME,
- "ns" -> ns.mkString("[", ", ", "]")))
+ "namespace" -> namespace.mkString(".")))
Review Comment:
Updated, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #39837: [SPARK-42254][SQL] Assign name to _LEGACY_ERROR_TEMP_1117
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #39837: [SPARK-42254][SQL] Assign name to _LEGACY_ERROR_TEMP_1117
URL: https://github.com/apache/spark/pull/39837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39837: [SPARK-42254][SQL] Assign name to _LEGACY_ERROR_TEMP_1117
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #39837:
URL: https://github.com/apache/spark/pull/39837#discussion_r1096574640
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -1239,12 +1239,12 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase {
new TableAlreadyExistsException(ident.asMultipartIdentifier)
}
- def requiresSinglePartNamespaceError(ns: Seq[String]): Throwable = {
+ def requiresSinglePartNamespaceError(namespace: Seq[String]): Throwable = {
new AnalysisException(
- errorClass = "_LEGACY_ERROR_TEMP_1117",
+ errorClass = "REQUIRES_SINGLE_PART_NAMESPACE",
messageParameters = Map(
"sessionCatalog" -> CatalogManager.SESSION_CATALOG_NAME,
- "ns" -> ns.mkString("[", ", ", "]")))
+ "namespace" -> namespace.mkString(".")))
Review Comment:
Please, quote the namespace id:
```suggestion
"namespace" -> toSQLId(namespace)))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org