You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Zoltan Haindrich (Jira)" <ji...@apache.org> on 2022/06/15 12:15:00 UTC
[jira] [Commented] (HIVE-25733) Add check-spelling CI action
[ https://issues.apache.org/jira/browse/HIVE-25733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554542#comment-17554542 ]
Zoltan Haindrich commented on HIVE-25733:
-----------------------------------------
thank you [~pvary], the action seems to be checking the PR state and not the one merged with the actual master...
thank you very much for fixing it!
> Add check-spelling CI action
> ----------------------------
>
> Key: HIVE-25733
> URL: https://issues.apache.org/jira/browse/HIVE-25733
> Project: Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Reporter: Josh Soref
> Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Add CI to catch spelling errors. See [https://www.check-spelling.dev/] for information.
> Initially this will only check the {{serde}} directory, but the intention is to expand its coverage as spelling errors in other directories are fixed.
> Note that for this to work the action should be made a required check, otherwise when a typo is added forks from that commit will get complaints.
> If a typo is intentional, the action will provide information about how to add it to {{expect.txt}} such that it will be accepted as an expected item (i.e. not a typo).
> To skip a file/directory entirely, add a matching entry to {{{}excludes.txt{}}}.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)