You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/06/11 22:25:19 UTC
Re: Review Request 35363: Improvements on libprocess/README.md.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35363/
-----------------------------------------------------------
(Updated June 11, 2015, 8:25 p.m.)
Review request for mesos and Bernd Mathiske.
Bugs: MESOS-2545
https://issues.apache.org/jira/browse/MESOS-2545
Repository: mesos
Description
-------
Improvements on libprocess/README.md.
Diffs
-----
3rdparty/libprocess/README.md 4dcd15042dd0b7105c903115cbe8875c3159365e
Diff: https://reviews.apache.org/r/35363/diff/
Testing
-------
Thanks,
Joerg Schad
Re: Review Request 35363: Improvements on libprocess/README.md.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35363/#review87641
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35363]
All tests passed.
- Mesos ReviewBot
On June 11, 2015, 8:40 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35363/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 8:40 p.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-2545
> https://issues.apache.org/jira/browse/MESOS-2545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improvements on libprocess/README.md.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 4dcd15042dd0b7105c903115cbe8875c3159365e
>
> Diff: https://reviews.apache.org/r/35363/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a6c5fd399bef8cb75b0d
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 35363: Improvements on libprocess/README.md.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On June 17, 2015, 1:58 p.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/README.md, lines 24-26
> > <https://reviews.apache.org/r/35363/diff/1/?file=982858#file982858line24>
> >
> > Feel free to drop this one, but I was considering to join these two single sentence paragraphs with something like:
> >
> > > Each process can be identified symbolically by its [PID](#pid).
> > > The ability to locate other processes through their pid allows
> > > basic communication between processes with the support of the
> > > methods [send](#send), [route](#route) and [install](#install)
as discussed
> On June 17, 2015, 1:58 p.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/README.md, line 267
> > <https://reviews.apache.org/r/35363/diff/1/?file=982858#file982858line267>
> >
> > It would be nice to point to some literature about promsises/futures.
> >
> > It would also be nice to describe what happens with broken promises (the promise object is destroyed before setting its value). Boost will throw an exception in this cases.
As discussed feel free to add this in a later iteration.
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35363/#review88204
-----------------------------------------------------------
On June 11, 2015, 8:40 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35363/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 8:40 p.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-2545
> https://issues.apache.org/jira/browse/MESOS-2545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improvements on libprocess/README.md.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 4dcd15042dd0b7105c903115cbe8875c3159365e
>
> Diff: https://reviews.apache.org/r/35363/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a6c5fd399bef8cb75b0d
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 35363: Improvements on libprocess/README.md.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On June 17, 2015, 1:58 p.m., Alexander Rojas wrote:
> >
Adressed your comments in https://reviews.apache.org/r/35568/.
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35363/#review88204
-----------------------------------------------------------
On June 11, 2015, 8:40 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35363/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 8:40 p.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-2545
> https://issues.apache.org/jira/browse/MESOS-2545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improvements on libprocess/README.md.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 4dcd15042dd0b7105c903115cbe8875c3159365e
>
> Diff: https://reviews.apache.org/r/35363/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a6c5fd399bef8cb75b0d
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 35363: Improvements on libprocess/README.md.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35363/#review88204
-----------------------------------------------------------
3rdparty/libprocess/README.md (line 19)
<https://reviews.apache.org/r/35363/#comment140597>
I'm not sure of starting a sentence with the prepodisition _to_. What about:
> … fasion. In order to always be responsive, processes should avoid blocking at all costs.
3rdparty/libprocess/README.md (lines 21 - 23)
<https://reviews.apache.org/r/35363/#comment140600>
Feel free to drop this one, but I was considering to join these two single sentence paragraphs with something like:
> Each process can be identified symbolically by its [PID](#pid).
> The ability to locate other processes through their pid allows
> basic communication between processes with the support of the
> methods [send](#send), [route](#route) and [install](#install)
3rdparty/libprocess/README.md (line 87)
<https://reviews.apache.org/r/35363/#comment140612>
I think this is missleading or at least confusing. A better description would be:
> `defer` allows the caller to postpone the decision wether to
> [dispatch](#dispatch) something by creating a callable object
> which actually performs the dispatch:
I will come with a better example later on.
3rdparty/libprocess/README.md (line 229)
<https://reviews.apache.org/r/35363/#comment140630>
It would be nice to point to some literature about promsises/futures.
It would also be nice to describe what happens with broken promises (the promise object is destroyed before setting its value). Boost will throw an exception in this cases.
For the latter parts, I think it would be nice to mention a little bit more about the threading model, for example, which thread executes a `then` callback?
- Alexander Rojas
On June 11, 2015, 10:40 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35363/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 10:40 p.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-2545
> https://issues.apache.org/jira/browse/MESOS-2545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improvements on libprocess/README.md.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 4dcd15042dd0b7105c903115cbe8875c3159365e
>
> Diff: https://reviews.apache.org/r/35363/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a6c5fd399bef8cb75b0d
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 35363: Improvements on libprocess/README.md.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35363/#review88226
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On June 11, 2015, 10:40 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35363/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 10:40 p.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-2545
> https://issues.apache.org/jira/browse/MESOS-2545
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improvements on libprocess/README.md.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 4dcd15042dd0b7105c903115cbe8875c3159365e
>
> Diff: https://reviews.apache.org/r/35363/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a6c5fd399bef8cb75b0d
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 35363: Improvements on libprocess/README.md.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35363/
-----------------------------------------------------------
(Updated June 11, 2015, 8:40 p.m.)
Review request for mesos and Bernd Mathiske.
Bugs: MESOS-2545
https://issues.apache.org/jira/browse/MESOS-2545
Repository: mesos
Description
-------
Improvements on libprocess/README.md.
Diffs
-----
3rdparty/libprocess/README.md 4dcd15042dd0b7105c903115cbe8875c3159365e
Diff: https://reviews.apache.org/r/35363/diff/
Testing (updated)
-------
Rendered version: https://gist.github.com/joerg84/a6c5fd399bef8cb75b0d
Thanks,
Joerg Schad